OpenStack Compute (nova)

Need --strict option for nova-manage cell_v2 discover_hosts

Bug #1692982 reported by Eric Berglund
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Wishlist
Eric Berglund

Bug Description

Description
===========
The "nova-manage cell_v2 discover_hosts" currently exits with code 0 unless something seriously breaks during the command execution. There should be a path for this command to exit with a failure code unless an unmapped host is found. If one is found, it should be considered a success.

Proposal
========
Add a --strict option (defaulting to false) to the nova-manage cell_v2 discover_hosts command. When this option is provided, the command will succeed with exit code 0 if any unmapped hosts are discovered. In any other case it will fail with exit code 1.

Eric Berglund (esberglu)
Changed in nova:
assignee: nobody → Eric Berglund (esberglu)
OpenStack Infra (hudson-openstack)
Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/467656

melanie witt (melwitt)
Changed in nova:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/467218
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=aaae213bf32096c56cb1bfcb4d0ac3cafd1c13fb
Submitter: Jenkins
Branch: master

commit aaae213bf32096c56cb1bfcb4d0ac3cafd1c13fb
Author: Eric Berglund <email address hidden>
Date: Tue May 23 22:26:28 2017 -0400

    Add strict option to discover_hosts

    This adds a --strict option that can be passed in when calling the
    nova-manage cell_v2 discover_hosts command. When this option is used,
    the command will only return success if a new host has been found.
    In any other case it is considered a failure.

    Closes-Bug: #1692982

    Change-Id: I942af11a3987e1edce67423c66931ad9ece65587

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.0.0b2

This issue was fixed in the openstack/nova 16.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/ocata)

Reviewed: https://review.openstack.org/467656
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a272023aa8a29db064f6a22b867fff2bf15089f1
Submitter: Jenkins
Branch: stable/ocata

commit a272023aa8a29db064f6a22b867fff2bf15089f1
Author: Eric Berglund <email address hidden>
Date: Tue May 23 22:26:28 2017 -0400

    Add strict option to discover_hosts

    This adds a --strict option that can be passed in when calling the
    nova-manage cell_v2 discover_hosts command. When this option is used,
    the command will only return success if a new host has been found.
    In any other case it is considered a failure.

    Closes-Bug: #1692982

    Change-Id: I942af11a3987e1edce67423c66931ad9ece65587
    (cherry picked from commit aaae213bf32096c56cb1bfcb4d0ac3cafd1c13fb)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 15.0.6

This issue was fixed in the openstack/nova 15.0.6 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.