Web Client checkout trims spaces from patron barcodes differently than xul client checkout

Related conversation in bug 1332651

I have submitted a fix for this here:
https://github.com/kcls/Evergreen/tree/user/showard/lp1629298-web_client_checkout_fails_for_barcodes_with_spaces
I added a step to remove any whitespaces before processing the barcode on that page in the web client.
To test, enter "99999 303411" at the checkout interface in the barcode submit field
Now reload the page from the menu and enter "99999303411" again.
Both times you should get the same result: it should correctly identify the patron rather than saying "Barcode not found." or the like.
-Skye

Oops I sent the wrong link - this is the correct one http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/showard/lp1629298-web_client_checkout_fails_for_barcodes_with_spaces

Worked for me, thanks Skye.

I've added a signoff branch here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1692986-webstaff_checkout_fails_for_barcodes_with_spaces-signoff

ps: I think Skye's branch name had a typo in the lp# part ("user/showard/lp1629298-web-client ...") thus I corrected that in the signoff branch above.

Thanks for getting that! -Skye

On Mon, Aug 28, 2017 at 9:32 AM, Cesar V <email address hidden> wrote:

> Worked for me, thanks Skye.
>
> I've added a signoff branch here: http://git.evergreen-
> ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/
> user/cesardv/lp1692986
> -webstaff_checkout_fails_for_barcodes_with_spaces-signoff
>
> ps: I think Skye's branch name had a typo in the lp# part
> ("user/showard/lp1629298-web-client ...") thus I corrected that in the
> signoff branch above.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1692986
>
> Title:
> Web Client checkout trims spaces from patron barcodes differently than
> xul client checkout
>
> Status in Evergreen:
> Confirmed
>
> Bug description:
> Evergreen 2.12
>
> If a patron barcode is entered with spaces between digits in the xul
> client Checkout interface, those spaces are trimmed out. Spaces are
> not trimmed out when the same barcode is entered in the web client
> Checkout interface.
>
> Steps to reproduce the problem using concerto data:
>
> At Checkout, enter patron barcode "99999 303411"
>
> xul client: Patron with barcode 99999303411 is retrieved
>
> web client: "Barcode Not Found: 99999 303411"
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1692986/+subscriptions
>

Pushed to master and rel_2_12. Thanks, Skye and Cesar!

Skye, I note that this appears to be your first commit accepted into Evergreen. Congratulations!