OpenStack Identity (keystone)

support HEAD requests for all GET /v3/* actions

Bug #1696574 reported by Lance Bragstad
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Wishlist
Lance Bragstad
OpenStack Identity (keystone) pike-3 "pike-3"

Bug Description

There was an effort in the past to ensure all GET APIs within keystone support corresponding HEAD methods [0]. This bug report is to cleanup the remaining APIs that have been introduced since then or overlooked.

The fix for this should be either updating each GET API to support HEAD using get_head_action or updating each get_action usage with a comment explaining why get_head_action isn't needed.

[0] https://bugs.launchpad.net/keystone/+bug/1370335

Lance Bragstad (lbragstad)
Changed in keystone:
status: New → Triaged
importance: Undecided → Low
importance: Low → Wishlist
tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/472858

Changed in keystone:
assignee: nobody → Lance Bragstad (lbragstad)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/472876

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/472881

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/473855

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/473882

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/473885

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/473891

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/473893

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/473902

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/473912

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by Lance Bragstad (<email address hidden>) on branch: master
Review: https://review.openstack.org/471919
Reason: This change is being abandon in favor of: https://review.openstack.org/#/q/status:open+project:openstack/keystone+branch:master+topic:bug/1696574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/472881
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=e156d337a7f426dce09c000f4d2e00ce16d115f1
Submitter: Jenkins
Branch: master

commit e156d337a7f426dce09c000f4d2e00ce16d115f1
Author: Lance Bragstad <email address hidden>
Date: Sat Jun 10 04:27:43 2017 +0000

    Add HEAD API to auth

    This commit adds HEAD counterparts to all GET APIs within the
    authentication API.

    There was also some inconsistencies in the existing documention
    saying a few GET APIs return 204 No Content when the response
    was actually 200 OK. This corrects that as well.

    Change-Id: Ic1f74b73e27a14428b129bed610d3d1d3d18f24e
    Partial-Bug: 1696574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/473855
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=5f4c2f5b8dca82b9f3a605d73bc987477a425468
Submitter: Jenkins
Branch: master

commit 5f4c2f5b8dca82b9f3a605d73bc987477a425468
Author: Lance Bragstad <email address hidden>
Date: Tue Jun 13 13:46:34 2017 +0000

    Ensure the endpoint filter API supports HEAD

    This commit makes it so all GET APIs within the endpoint filter API
    support HEAD as well.

    Change-Id: I6dd8b3f7494003bca110623a3b8133c81ff90877
    Partial-Bug: 1696574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/472876
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=b56dc828221cb0ea5ab33acb0c09b61c24012e6e
Submitter: Jenkins
Branch: master

commit b56dc828221cb0ea5ab33acb0c09b61c24012e6e
Author: Lance Bragstad <email address hidden>
Date: Sat Jun 10 03:51:03 2017 +0000

    Add HEAD API to domain config

    The domain configuration API had several GET calls that didn't
    support HEAD. The documentation for the added HEAD APIs is going
    to be proposed at a later date as a blanket statement saying all
    APIs the support GET also support HEAD. This reduces duplication
    of documentation for a relatively straight-forward concept.

    This commit also fixes some inconsistencies in the domain
    configuration documentation with colons and newlines.

    Change-Id: I7a6ab2f05600c8d562d5be83d651ff735c9a68a4
    Partial-Bug: 1696574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/473882
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=17cfe62e8fdc9459d26a899c3036c73d4a64fac4
Submitter: Jenkins
Branch: master

commit 17cfe62e8fdc9459d26a899c3036c73d4a64fac4
Author: Lance Bragstad <email address hidden>
Date: Tue Jun 13 15:15:41 2017 +0000

    Ensure the ec2 API supports HEAD

    This commit makes it so all GET APIs within the ec2 API
    support HEAD. This change doesn't include any tests because
    the ec2 API is untested, see bug 1635389 for more details.

    Change-Id: Iab7326d0758425f535c57c64f9cdca5f2e8d122b
    Partial-Bug: 1696574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/473891
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=630342aba32a8f94205e2fa1565138696715322c
Submitter: Jenkins
Branch: master

commit 630342aba32a8f94205e2fa1565138696715322c
Author: Lance Bragstad <email address hidden>
Date: Tue Jun 13 15:56:50 2017 +0000

    Ensure oauth API supports HEAD

    This commit makes it so all oauth GET APIs also support HEAD.

    Change-Id: Ie0eebfa662de850856ecb92c2aba61af41b6c8f6
    Partial-Bug: 1696574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/473902
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=37d73b15b0ef0402a5c610e7126b3f72520bbb65
Submitter: Jenkins
Branch: master

commit 37d73b15b0ef0402a5c610e7126b3f72520bbb65
Author: Lance Bragstad <email address hidden>
Date: Tue Jun 13 16:10:14 2017 +0000

    Ensure the trust API supports HEAD requests

    This commit makes it so all GET requests in the trust API also
    support HEAD.

    Change-Id: I6b6ec5cbd651a601a18b04428183b21044305be7
    Partial-Bug: 1696574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/473893
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=9d0f7a53571173ea401579202cc5d54debdd90c3
Submitter: Jenkins
Branch: master

commit 9d0f7a53571173ea401579202cc5d54debdd90c3
Author: Lance Bragstad <email address hidden>
Date: Tue Jun 13 16:03:38 2017 +0000

    Ensure HEAD is supported with simple cert

    This changes makes it so simple cert GET requests also support HEAD.

    Change-Id: Id930c783a7adf96e3a3bf41b527df83735c9fbd5
    Partial-Bug: 1696574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/473885
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=b272068e52489ec2aea53be87637aea8510afe7b
Submitter: Jenkins
Branch: master

commit b272068e52489ec2aea53be87637aea8510afe7b
Author: Lance Bragstad <email address hidden>
Date: Tue Jun 13 15:42:11 2017 +0000

    Ensure the endpoint policy API supports HEAD

    This commit makes it so all endpoint policy GET APIs also support
    HEAD.

    Change-Id: Ib8eada4847506cc41eeb1e323752473608c38df5
    Partial-Bug: 1696574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/472858
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=d7b13fd368fb6ff2322ddcf6edfc1203d75cc5db
Submitter: Jenkins
Branch: master

commit d7b13fd368fb6ff2322ddcf6edfc1203d75cc5db
Author: Lance Bragstad <email address hidden>
Date: Mon Jun 12 21:57:54 2017 +0000

    Add HEAD APIs to federated API

    This commit ensures that all Federated GET APIs have a corresponding
    HEAD API if not already specified. This is to be consistent with
    other APIs in keystone.

    Change-Id: Ifc7c9d73eca9f715a0f3f25701bcee389ddc354d
    Partial-Bug: 1696574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/478284

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/473912
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=bece59e6716417644a8a6522b5c994fef5d38168
Submitter: Jenkins
Branch: master

commit bece59e6716417644a8a6522b5c994fef5d38168
Author: Lance Bragstad <email address hidden>
Date: Tue Jun 13 16:40:32 2017 +0000

    Implement HEAD for assignment API

    This commit makes it so all assignment GET APIs also support HEAD.

    Change-Id: I9b05d9853f8fb434ad3da76e0981f0206e9c9d6e
    Partial-Bug: 1696574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/478284
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=eb274afdb411e3de74ca36b5aad0b41a79089e77
Submitter: Jenkins
Branch: master

commit eb274afdb411e3de74ca36b5aad0b41a79089e77
Author: Lance Bragstad <email address hidden>
Date: Tue Jun 27 21:04:06 2017 +0000

    Document and add release note for HEAD APIs

    Now that all GET APIs have a corresponding HEAD API, we can add a
    formal statement about support and a release note.

    Change-Id: Ia5569311f91d87b40d064595ce2c8d69461fbab7
    Closes-Bug: 1696574

Changed in keystone:
status: In Progress → Fix Released
Lance Bragstad (lbragstad)
Changed in keystone:
milestone: none → pike-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 12.0.0.0b3

This issue was fixed in the openstack/keystone 12.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.