Cinder

attach_delete removes export when multiple connections exist

Bug #1697008 reported by Steve Noyes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
John Griffith

Bug Description

v3 cinder api attachment_delete ignores the has_shared_connection flag returned from connection_terminate. This has the unfortunate effect of causing other connections to the volume to lose their connection.

I saw this while debugging live migration. At the end of the migration, the source host does an attachment_delete to remove the attachment. attachment_delete, being oblivious to the other connection to the destination host, removes the volume export and cuts the connection between the destination host and the volume.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/472796

Changed in cinder:
assignee: nobody → Steve Noyes (steve-noyes)
status: New → In Progress
OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: Steve Noyes (steve-noyes) → John Griffith (john-griffith)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/472796
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=345189153191abe55a922ba49593ca09b9b65540
Submitter: Jenkins
Branch: master

commit 345189153191abe55a922ba49593ca09b9b65540
Author: Steve Noyes <email address hidden>
Date: Fri Jun 9 11:14:31 2017 -0400

    Update attachment_delete for multiple attachments

    - change attachment_delete to not remove the export if multiple
    attachments exist

    Also remove the unused return of has_shared_connections in
    attachment_delete method. It's not used or needed in this
    method.

    Closes-Bug: 1697008

    Change-Id: I62b90c4cd4ad2bfb8a68718b43dc606e02fe776a

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 11.0.0.0b3

This issue was fixed in the openstack/cinder 11.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.