rsyslog client postrotate script contains invalid command
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack-Ansible |
Fix Released
|
High
|
Jean-Philippe Evrard | ||
Bug Description
Both 14 (Newton) and 15 (Ocata) tags
From rsyslog_
```
rsyslog_
- name: postrotate
content: "restart rsyslog 2>&1 || true"
```
This gets deployed as the following in logrotate files, e.g. /etc/logrotate.
```
/var/log/
[...22 more logfiles...]
{
weekly
missingok
rotate 14
compress
dateext
maxage 60
notifempty
nocreate
postrotate
restart rsyslog 2>&1 || true
endscript
}
```
Unfortunately, `restart` is an upstart-ism and doesn't exist in the systemd world of Ubuntu 16.04, so this doesn't actually restart the rsyslog service.
It appears that now with Ocata, logrotate scripts are now also deployed to hosts (not just containers), to rotate the logfiles for each LXC. My hosts email me the contents of stderr from anything run by cron, so now this shows up in my email:
```
/etc/cron.
logrotate_script: 2: logrotate_script: restart: not found
[...22 more identical lines...]
```
I tried changing the postrotate script to `systemctl restart rsyslog 2>&1 || true`. This doesn't cause an error which results in an email, but it also doesn't actually restart the rsyslog service, and I don't know why. Maybe it's a file permissions issue, or something with selinux?
| Jean-Philippe Evrard (jean-philippe-evrard) wrote | #1 |
| Changed in openstack-ansible: | |
| status: | New → Confirmed |
| tags: | added: low-hanging-fruit |
| Changed in openstack-ansible: | |
| importance: | Undecided → High |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to openstack-ansible-rsyslog_client (master) | #2 |
| Changed in openstack-ansible: | |
| assignee: | nobody → Jean-Philippe Evrard (jean-philippe-evrard) |
| status: | Confirmed → In Progress |
| OpenStack Infra (hudson-openstack) wrote Fix merged to openstack-ansible-rsyslog_client (master) | #3 |
| Changed in openstack-ansible: | |
| status: | In Progress → Fix Released |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to openstack-ansible-rsyslog_client (stable/pike) | #4 |
| OpenStack Infra (hudson-openstack) wrote Fix merged to openstack-ansible-rsyslog_client (stable/pike) | #5 |
| tags: | added: in-stable-pike |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to openstack-ansible-rsyslog_client (stable/ocata) | #6 |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to openstack-ansible-rsyslog_client (stable/newton) | #7 |
| OpenStack Infra (hudson-openstack) wrote Fix merged to openstack-ansible-rsyslog_client (stable/newton) | #8 |
| tags: | added: in-stable-newton |
| OpenStack Infra (hudson-openstack) wrote Fix included in openstack/openstack-ansible-rsyslog_client 17.0.0.0b1 | #9 |
| OpenStack Infra (hudson-openstack) wrote Fix included in openstack/openstack-ansible-rsyslog_client 16.0.2 | #10 |
| OpenStack Infra (hudson-openstack) wrote Fix included in openstack/openstack-ansible-rsyslog_client 15.1.12 | #11 |
| OpenStack Infra (hudson-openstack) wrote Fix included in openstack/openstack-ansible-rsyslog_client 14.2.12 | #12 |
We should be templating depending on the ansible_