lsvpd: Do not run vpdupdate during installation

Hi Vasant,
does that mean that we don't need to run vpdupdate on both, installation of a new package, and upgrade of the package ?
If so, what is vpdupdate binary needed for ? Do we still need to keep it packaged ?
Regards,

F.

Steve, https://packages.ubuntu.com/xenial/lsvpd is a universe package, and I believe it was removed from the newer releases (artful). Does DI use lsvpd for collecting any data?

On Mon, Oct 02, 2017 at 02:00:42PM -0000, Manoj Iyer wrote:
> Steve, https://packages.ubuntu.com/xenial/lsvpd is a universe package,
> and I believe it was removed from the newer releases (artful).

On the contrary, the package has been promoted to main in zesty and artful.

> Does DI use lsvpd for collecting any data?

No, it does not; it is a dependency of ppc64-diag, the installer itself does
not use it.

------- Comment From <email address hidden> 2017-10-03 13:41 EDT-------
(In reply to comment #4)
> Hi Vasant,
> does that mean that we don't need to run vpdupdate on both, installation of
> a new package, and upgrade of the package ?

Yes.

> If so, what is vpdupdate binary needed for ? Do we still need to keep it
> packaged ?

Yes. Let me try to make it clear. vpdupdate command collect system vpd from various source and creates static sqlite db under /var/lib/lsvpd and everytime when something changes we had to run this command manually. Sometime back we added udev script to detect changes in sysfs and run vpdupdate automatically next time whenever lscfg/lsvpd is ran.

Hence I'm thinking lets not run this command during install. Lets defer until user calls lsvpd/lscfg first time.

-Vasant

------- Comment From <email address hidden> 2017-10-03 13:53 EDT-------
(In reply to comment #6)
> On Mon, Oct 02, 2017 at 02:00:42PM -0000, Manoj Iyer wrote:
> > Steve, https://packages.ubuntu.com/xenial/lsvpd is a universe package,
> > and I believe it was removed from the newer releases (artful).
>
> On the contrary, the package has been promoted to main in zesty and artful.

Yes. That was our request.

-Vasant

On Tue, Oct 03, 2017 at 05:49:19PM -0000, bugproxy wrote:
> Yes. Let me try to make it clear. vpdupdate command collect system vpd
> from various source and creates static sqlite db under /var/lib/lsvpd
> and everytime when something changes we had to run this command
> manually. Sometime back we added udev script to detect changes in sysfs
> and run vpdupdate automatically next time whenever lscfg/lsvpd is ran.

> Hence I'm thinking lets not run this command during install. Lets defer
> until user calls lsvpd/lscfg first time.

Does this trade an install-time delay against a delay the first time the
user runs the command?

Or, since the udev rule sets the flag each time it's run, will there always
be a delay on the first run after each reboot, thus making the install-time
generation pointless?

------- Comment From <email address hidden> 2017-10-10 14:16 EDT-------
(In reply to comment #9)
> On Tue, Oct 03, 2017 at 05:49:19PM -0000, bugproxy wrote:
> > Yes. Let me try to make it clear. vpdupdate command collect system vpd
> > from various source and creates static sqlite db under /var/lib/lsvpd
> > and everytime when something changes we had to run this command
> > manually. Sometime back we added udev script to detect changes in sysfs
> > and run vpdupdate automatically next time whenever lscfg/lsvpd is ran.
>
> > Hence I'm thinking lets not run this command during install. Lets defer
> > until user calls lsvpd/lscfg first time.
>
> Does this trade an install-time delay against a delay the first time the
> user runs the command?

Somewhat yes. It will definitely avoid install time delay.

On runtime whenever udev script trigger (like after reboot), we will rerun vpdupdate and it will have delay... which is fine.

>
> Or, since the udev rule sets the flag each time it's run, will there always
> be a delay on the first run after each reboot, thus making the install-time
> generation pointless?

yes.

-Vasant

This bug was fixed in the package lsvpd - 1.7.8-2

---------------
lsvpd (1.7.8-2) unstable; urgency=medium

  * d/postinst : removed as vpd database is updated at runtime now (LP:
    #1720304)

 -- Frédéric Bonnard <email address hidden> Wed, 04 Oct 2017 07:00:57 +0000