Import failure on translation credits

Bug #173144 reported by Jeroen T. Vermeulen
20
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Jeroen T. Vermeulen

Bug Description

A translation import can fail with this sort of error:

http://launchpadlibrarian.net/10673357/xSPkX9EbRQqU4Jy64daqZfPTzG9.txt

POTMsgSet.updateTranslation() returned None. That can only happen when updating a translation credits message, without the is_imported parameter set.

Indeed, the failed upload here was a PO file that contained:

msgid "translator-credits"
msgstr ""

Changed in rosetta:
assignee: nobody → jtv
importance: Undecided → Medium
milestone: none → 1.1.12
status: New → In Progress
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

To avoid this problem, remove or comment out any translator credits strings from your translation. For translations made in Launchpad (where this bug occurs) the system will generate these credits automatically anyway. Credit strings are meaningless in that case.

Translator credits strings have a msgid of "translator-credits", "translation-credits", "translator_credits", "EMAIL OF TRANSLATORS\nYour emails", or "NAME OF TRANSLATORS\nYour names".

If your imports have been failing quietly but you do not have any translator credits strings, or you were importing upstream translations (where credits strings do make sense), you may also be running into bug 173670.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Fixed in RF 5304.

Changed in rosetta:
status: In Progress → Fix Committed
Revision history for this message
Adi Roiban (adiroiban) wrote :

I'm using - build 5313 and I think I can still reproduce this bug.

Initially I wrote a comment on bug #2038 , due to the fact there is no failure notification.

I'm trying to import this file ( http://launchpadlibrarian.net/10833980/ro.po ) and it fails without a notification message.

Revision history for this message
Данило Шеган (danilo) wrote :

Adi, as I confirmed in that bug, you are hitting this problem. Bug has been fixed, but not yet "released". Once it's marked as 'fix released', it will mean problem will be fixed for you. A work-around is described here.

Revision history for this message
Adi Roiban (adiroiban) wrote :

Sorry for this situation! I don't know what RF or Fixed commited means. (there is no help available for this page :(

I was thinking that Fix commited together with Fixed in RF 5304 was saying that this bug is available in edge.launchpad.net build 5313

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Adi, that is correct but unfortunately this bit of processing does not happen on edge itself.

I'm still trying to figure out how your upload can still fail with this error once you've removed the credits message.

Revision history for this message
Adi Roiban (adiroiban) wrote :

There is another bug in launchpad that could trigger this silent failure.

Romanian has 3 plural forms, but if I'm exporting a PO file from rosetta the resulting PO file has only 2 plural forms.
I'm importing the PO files without changing the strings with plural forms. So the imported strings have only 2 plural forms.

Maybe this is related to bug #70470 (in work by Danilo Sergan).

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Interesting idea! I don't think it's exactly bug 70470 (since AFAICS your PO file specifies the same plural-form information that we have registered for the language) but it might be related.

I notice that where you have untranslated multi-form messages in your PO file, you have two empty translations instead of three. Maybe it's that? If so, it would seem to be related to 173670. The difference is that the error message we see in the logs is the one for the translation-credits bug (the one this report is about) and I don't see any other way in the code for that message to appear.

Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.