web client: item status list view display issues

Adding a note that the following are addressed in the branch at bug 1738249.

- Circulation library is circulating library
- Remaining renewals doesn't display

Release 3.0.3

Items with the Holdable field set to False display as set to True in Item Status Detail View and List View.

I'm setting the importance to High because it has been identified to me as critical to fix this.

Owning library displays numerical code rather than short policy name --
 per comment #6 on bug 1738240, this was addressed as part of bug 1738249 (which has a pullrequest, if anyone would like to review).

> Circ?,hold,ref? true/false rather than yes/no

this is not specific to this view. all datatype="bool" fields show "true"/"false" instead of "yes"/"no".

Open-ILS/web/js/ui/default/staff/services/grid.js coerces true/false value to (translated) string in javascript: ''+true

comments say: 'Translates bools to Booleans so the browser can display translated value. (Though we could manaully translate instead..)'

pushed branch http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/abellenir/lp1743801-copy-status-columns

it fixes the age protection and displays strings for fine level and loan duration.

> Circulation library is circulating library
i don't understand. is the label wrong or the contents?

> Remaining renewals doesn't display
works for me. remaining renewals is blank for available items, but showed up for items that were checked out.

> Circ as type displays as MARC code
i can replicate, but haven't figured out a fix yet.

As mentioned in comment #1, the circulation library is circulating library issue and the remaining renewals issues were addressed in another bug. Some other issues may have been addressed there too. It probably would be a good idea to review the original report and see which are still relevant and which are taken care of.

attaching an optional patch to display "Yes" or "No" instead of "true" or "false" for datatype=bool fields in grids.

NOTE: this effects all datatype=bool fields in grids.

updated branch user/abellenir/lp1743801-copy-status-columns (http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/abellenir/lp1743801-copy-status-columns) with fleshed circ_as_type field to display desired value.

fixes are now available for all issues in the original report.

Thank you for the code contribution idjit! It works for me, and I've pushed a signoff to the working repo at:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1743801-copy-status-columns-signoff

I held off on merging it because I would like a second opinion on the way you handled the loan duration and the fine level. The cause for my hesitation was that future development (or possible configuration?) could expand the number of duration and fine levels, but this assumes that there are three distinct levels.

On the other hand, we're already doing something very similar in current Evergreen in the item status full detail view, so it may be perfectly fine. Does anyone else have thoughts on this?

I tested the fix in 3.1 and it fixes everything listed (and not already fixed elsewhere) except for the issue of true/false versus yes/no.

Should the true/false versus yes/no issue be split into a separate bug report so the patch can be commented on and a decision made about whether it should be included in upstream?

Jennifer,

ideally, yes.

from irc (http://irc.evergreen-ils.org/evergreen/2018-06-08#i_363534):
kmlussier: [...] I was going to suggest a new bug for it if people still thought it was an issue. [...]

true/false vs yes/no is also referenced in bug 1741347.

Kathy, I have no concerns about your fine level question. As it stands, the levels are hard-coded in the DB. IF they change later, we'll just have to the change the UI to match. I did not test the code, but I did review it, and +1 to merging.

After applying this to our test servers, I am still not seeing the same issues with attribute display.

I opened bug 1788417 to address the "true"/"false" "Yes"/"No" issue since it affects all boolean fields in the grids.

Tested the branch this morning with 3.0 and it works for me. I pushed to master, rel_3_1, and rel_3_0.

Thanks, a. bellenir, Kathy, and everyone else!