Snapd fails to start (failed to parse /proc/self/mountinfo)

Thanks for your bugreport. We improved the robustness of this code path - can you please try with snapd 2.32.5 which is available in bionic now.

I think this is still a TODO for me mvo. I fixed fstab without touching mountinfo IIRC. I will address this today.

I looked into this issue and pushed a fix here: https://github.com/snapcore/snapd/compare/master...mvo5:lp-1763266?expand=1

However this looks like a bcachefs bug to me, most filesystems use "seq_show_option" to display stuff in mountinfo. And seq_show_options() will seq_escape() spaces: `seq_escape(m, value, ", \t\n\\");`.

I looked into this some more and I think this is a bcachefs bug. It does not do any escaping for the mountinfo options. This is done by other filesystems like ext4. The following might fix it:
"""
diff --git a/fs/bcachefs/opts.c b/fs/bcachefs/opts.c
index 8db8096e5ed4..4ebe557dfbaf 100644
--- a/fs/bcachefs/opts.c
+++ b/fs/bcachefs/opts.c
@@ -242,11 +242,11 @@ int bch2_opt_to_text(struct bch_fs *c, char *buf, size_t len,

        if (flags & OPT_SHOW_MOUNT_STYLE) {
                if (opt->type == BCH_OPT_BOOL)
- return scnprintf(out, end - out, "%s%s",
+ return scnprintf(out, end - out, "%pEc%s",
                                         v ? "" : "no",
                                         opt->attr.name);

- out += scnprintf(out, end - out, "%s=", opt->attr.name);
+ out += scnprintf(out, end - out, "%pEc=", opt->attr.name);
        }

        switch (opt->type) {
diff --git a/fs/bcachefs/util.c b/fs/bcachefs/util.c
index fa8537502fed..ca524bac27b0 100644
--- a/fs/bcachefs/util.c
+++ b/fs/bcachefs/util.c
@@ -115,7 +115,7 @@ ssize_t bch2_scnprint_string_list(char *buf, size_t size,

        for (i = 0; list[i]; i++)
                out += scnprintf(out, buf + size - out,
- i == selected ? "[%s] " : "%s ", list[i]);
+ i == selected ? "[%pEc] " : "%pEc ", list[i]);

        if (out != buf)
                *--out = '\0';
"""
Or it might crash your kernel. If it helps we should send it to the bcachefs mailing list. I think this should also be turned an upstream bcachefs bugreport (probably via the bcachefs mailinglist?).

The first bit of the diff is wrong, but should not matter for the test, the bch2_scnprint_string_list() is what I suspect needs the escaping.

Note that this "fix" is incomplete issofar that the options should also escape the "=" char.

[Expired for snapd (Ubuntu) because there has been no activity for 60 days.]