tripleo

[QUEENS] Promotion Jobs failing at overcloud deployment with AttributeError: 'IronicNodeState' object has no attribute 'failed_builds'

Bug #1776596 reported by yatin on 2018-06-13

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Undecided	Unassigned
	tripleo	Fix Released	Critical	yatin	tripleo rocky-3

Bug Description

Queens overcloud deployment in all ovb promotion jobs is failing with AttributeError: 'IronicNodeState' object has no attribute 'failed_builds'.

Logs:-
https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-queens-upload/556a09f/undercloud/home/jenkins/failed_deployment_list.log.txt.gz
https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-queens-upload/556a09f/undercloud/var/log/nova/nova-scheduler.log.txt.gz#_2018-06-13_01_08_25_689
https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset020-queens/3909a7f/undercloud/home/jenkins/failed_deployment_list.log.txt.gz

This is happening with a cherry-picked patch in nova:- https://review.openstack.org/#/c/573239/

In master it's not seen probably because of:- https://review.openstack.org/#/c/565805/ (Remove IronicHostManager and baremetal scheduling options)

See original description

Tags:

yatin (yatinkarel) on 2018-06-13

description:

updated

Revision history for this message

Tony Breeds (o-tony) wrote on 2018-06-13:

It looks like when we backported https://review.openstack.org/#/c/573248 to queens (and pike) we missed the fact that the Ironic Host Manger is still in queens and needs an update that wasn't needed on master becuase we removed it in https://review.openstack.org/#/c/565805/1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-13: Fix proposed to nova (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/574997

yatin (yatinkarel) on 2018-06-13

Changed in tripleo:
status:	New → Confirmed

yatin (yatinkarel) on 2018-06-13

tags:

added: alert ci promotion-blocker

Takashi Natsume (natsume-takashi) on 2018-06-13

tags:	added: ironic removed: alert ci promotion-blocker
tags:	added: alert ci promotion-blocker

Arx Cruz (arxcruz) on 2018-06-13

Changed in tripleo:
importance:	Undecided → Critical
assignee:	nobody → yatin (yatinkarel)
status:	Confirmed → Triaged

Arx Cruz (arxcruz) on 2018-06-13

Changed in tripleo:
milestone:	none → rocky-3

Revision history for this message

Quique Llorente (quiquell) wrote on 2018-06-14:

Temp patch fomr yatin https://review.rdoproject.org/r/#/c/14226/

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-14: Fix merged to nova (stable/queens)

Reviewed: https://review.openstack.org/574997
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d26dc0ca03e9cc9a04ac02d88ba2d2867340f5cd
Submitter: Zuul
Branch: stable/queens

commit d26dc0ca03e9cc9a04ac02d88ba2d2867340f5cd
Author: Tony Breeds <email address hidden>
Date: Wed Jun 13 16:07:28 2018 +1000

[Stable Only] Initialise failed_builds in IronicNodeState

    When we merged I71c56fe770f8c3f66db97fa542fdfdf2b9865fb8 we introduced a
    regression in the ironic host manager as it doesn't setup a
    failed_builds attribute. We didn't need to do this on master as the
    host manager in question is already removed due to
    I695b250c82c8dcedcd8e2bee00c56bb2df19212c

    Depends-On: https://review.openstack.org/#/c/575132/
    Change-Id: Ia52dda42208398b4f719fa3023dd10d9642b1e02
    Closes-Bug: 1776596

tags:

added: in-stable-queens

Quique Llorente (quiquell) on 2018-06-14

Changed in tripleo:
status:	Triaged → Fix Committed

yatin (yatinkarel) on 2018-06-14

tags:

removed: alert promotion-blocker

Quique Llorente (quiquell) on 2018-06-14

Changed in nova:
status:	New → Fix Released

Revision history for this message

wes hayutin (weshayutin) wrote on 2018-06-14:

https://review.rdoproject.org/jenkins/job/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-queens-upload/296/console

Changed in tripleo:
status:	Fix Committed → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-15: Fix proposed to nova (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/575612

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-18: Change abandoned on nova (stable/pike)

Change abandoned by Tony Breeds (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/575612
Reason: Squashed into parent commit

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-24: Fix included in openstack/nova 17.0.6

This issue was fixed in the openstack/nova 17.0.6 release.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.