Extending circ due date can result in exceeding max fines

IRC discussion for reference:

http://irc.evergreen-ils.org/evergreen/2018-08-09#i_371513

The gist is we want to continue the practice of resuming overdues after the newly applied due_date without back-filling overdues, however we also want to know the amount billed as overdue fines from all existing fines before applying new ones, not just those that were created after the new due date.

Confirmed

Just ran into this today as a result of a lot of COVID-related manual due date adjustments. Should be a simple thing to retain the current logic while also reporting the correct amount billed so far by the patron.

Here's a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1786312-due-date-extend-exceed-max-fines

I should have noted during feedback week that I'm actively testing this bug. The fine generation is being a bit slow to reach max fines.

I know Erica is looking at this fix, but I am trying to reproduce the bug in a master circa 3.7.1 system without the fix, and am not able to. Possibly, I could be missing something.

I cannot reproduce it when I follow the steps in the description to approximate it in Concerto. Here are my steps:

- Verify that action.circulation.id 7 has stop_fines and stop_fines_time set.

- Update action.circulation.id 7 to have stop_fines_time and stop_fines of NULL:

update action.circulation
set stop_fines = NULL,
stop_fines_time = NULL
where id = 7

- Run the fine generator

- Note that the total overdue fines due for the transaction has not changed

- Check stop_fines and stop_fines_time in the circ

select stop_fines_time, stop_fines
from action.circulation
where id = 7

This reveals that stop_fines = MAXFINES and stop_fines_time is the time the fine generator was run.

I will attempt to modify the due date in a circulation as described in the first procedure and rerun the fine generator when the new due date has passed.

I did note that when I choose a circulation in the client that has acheived MAXFINES and choose Edit Due Date under Actions, the circulation retains the MAXFINES stop_fines and stop_fines_time.

Noting that I was testing the patch over several weeks. It did not recreate a scenario where charges were still applying after max fines. In reading Michele's comment, I'm wondering if the Library Setting Truncate fines to max fine amount's value plays a role in what users experience.

Bill, do you have any advice on how to create the scenario that this would fix?

I left out the most important part: you have update the due date as well.

1. Run the fine generator as usual

You should see this:

evergreen=# select sum(amount) from money.billing where xact = 7;
-[ RECORD 1 ]
sum | 0.70

2. Modify Circ 7 to change its due date and clear stop fines data

evergreen=# update action.circulation set stop_fines = null, stop_fines_time = null, due_date = now() - '2 weeks'::interval where id = 7;

3. Run the fine generator again.

Then you'll see this:

evergreen=# select sum(amount) from money.billing where xact = 7 and not voided;
-[ RECORD 1 ]
sum | 1.40

====

Note that clearing the stop fines data is only necessary in this contrived example. In the wild, this happens to circulations that are still accruing fines.

Rebased branch pushed here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1786312-due-date-extend-exceed-max-fines-v2

Includes a fix to the logic where "gt" should have been used instead of ">".