Evergreen

APPLY_WORKSTATION_SETTING perm description needs repair

Bug #1795972 reported by Bill Erickson
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
Evergreen 3.4-beta1

Bug Description

Evergreen 3.2

The seed data entry for the permission APPLY_WORKSTATION_SETTING contains the value "APPLY_WORKSTATION_SETTING" as the description of the permission instead of a user-friendly description.

http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/sql/Pg/950.data.seed-values.sql;h=949021b83d90ad92c55262adcb55abc86f0a0354;hb=HEAD#l1913

Tiffany Little (tslittle)
tags: added: permissions
Revision history for this message
Chris Sharp (chrissharp123) wrote :

I have created a branch for this:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1795972_apply_workstation_setting_desc

Changed in evergreen:
importance: Undecided → Low
status: New → Confirmed
milestone: none → 3.4-beta1
Chris Sharp (chrissharp123)
tags: added: pullrequest
Kyle Huckins (khuckins)
Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
Revision history for this message
Kyle Huckins (khuckins) wrote :

Testing on the latest master, this works, though I'm wondering if the upgrade script should use oils_i18n_gettext() so it's nice and translatable.

Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
assignee: nobody → Kyle Huckins (khuckins)
Revision history for this message
Kyle Huckins (khuckins) wrote :

I've pushed a sign-off branch here, making that recommended change: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1795972-apply-workstation-setting-desc-signoff

Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master for inclusion in 3.4. Thanks, Chris and Kyle!

I don't view this as worth backporting but wouldn't object if anybody else wants to.

Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
assignee: Galen Charlton (gmc) → nobody
status: Confirmed → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.