Ubuntu
kdebase package

{kubuntu} bashism in /usr/bin/startkde

Bug #179631 reported by Edward Shornock on 2008-01-01

Affects		Status	Importance	Assigned to	Milestone
	kdebase (Ubuntu)	Invalid	Medium	Unassigned
Nominated for Hardy by Harald Sitter

Bug Description

SRU:
1. Because of this bug prelinking doesn't work properly in KDE, to enable this feature the attached patch is necessary.
2. The bug did not get addressed in the development branch at all, since the affected patch is not applied on the KDE 4 packages (which replace the affected package in Intrepid)
3 . Patch attached
4. TEST CASE:
* install patched package
* install prelink package
* ensure PRELINKING is set to yes in /etc/default/prelink
* start KDE
* the command 'env | grep PRELINK' on a prompt should output
KDE_IS_PRELINKED=1
thus improving KDE's speed
5. There is no regression potential since currently this feature doesn't work at all, so it can't get any worse really ;-)

--------------------------------

Binary package hint: ksmserver

In ~/.xsession-errors one can see

[: 41: ==: unexpected operator

It turns out that it's a bashism in /usr/bin/startkde that causes it.

--- kubuntu_17_check_for_prelinking.diff 2007-12-31 20:44:54.000000000 -0500
+++ kubuntu_17_check_for_prelinking.diff.fixed 2007-12-31 20:45:56.000000000 -0500
@@ -9,7 +9,7 @@
+# loading KDE.
+if test -f /etc/default/prelink; then
+ . /etc/default/prelink
-+ if [ "$PRELINKING" == yes ]; then
++ if [ "$PRELINKING" = yes ]; then
+ export KDE_IS_PRELINKED=1
+ fi
+fi

See original description

Daniel Hahler (blueyed) on 2008-01-03

Changed in kdebase:
importance:	Undecided → Medium
status:	New → Triaged

Revision history for this message

Harald Sitter (apachelogger) wrote on 2008-07-11:

No such line in KDE 4's startkde - closing as invalid.

Thank you for this report nonetheless

Changed in kdebase:
status:	Triaged → Invalid

Revision history for this message

Edward Shornock (ed-shornock+launchpad) wrote on 2008-07-11:

...that's great...it *IS* in the version in hardy so there's no way this is invalid!

I just downloaded the package and checked it.

:/tmp$ wget http://ubuntu.uni-klu.ac.at/ubuntu/pool/main/k/kdebase/ksmserver_3.5.9-0ubuntu7.2_amd64.deb
--2008-07-11 18:20:37-- http://ubuntu.uni-klu.ac.at/ubuntu/pool/main/k/kdebase/ksmserver_3.5.9-0ubuntu7.2_amd64.deb
Resolving ubuntu.uni-klu.ac.at... 143.205.176.54
Connecting to ubuntu.uni-klu.ac.at|143.205.176.54|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 156520 (153K) [application/x-debian-package]
Saving to: `ksmserver_3.5.9-0ubuntu7.2_amd64.deb'

100%[======================================>] 156,520 389K/s in 0.4s

2008-07-11 18:20:38 (389 KB/s) - `ksmserver_3.5.9-0ubuntu7.2_amd64.deb' saved [156520/156520]

:~/tmp$ dpkg-deb -x ksmserver_3.5.9-0ubuntu7.2_amd64.deb ext/
:~/tmp$ cd ext/
:~/tmp/ext$ grep PRELINK usr/bin/startkde
# Check if prelinking is enabled. If so, exporting KDE_IS_PRELINKED improves
        if [ "$PRELINKING" == yes ]; then
                export KDE_IS_PRELINKED=1
:~/tmp/ext$ checkbashisms usr/bin/startkde
possible bashism in usr/bin/startkde line 32 (should be 'b = a'):
        if [ "$PRELINKING" == yes ]; then
possible bashism in usr/bin/startkde line 372 ($UID should be "$(id -ru)"):
KDE_SESSION_UID=$UID