[upstream] LibreOffice Impress embed video broken outside slide

Created attachment 150705
a presentation with a various of combination with a sample video

Description:

On my Ubuntu 18.04 LTS, I observe that when a video is crossing boundaries (only right or bottom) of a slide, it causes the slide to zoom in during slide show.

Steps to Reproduce:
1. Add a linked or embedded video to slide.
2. Move the video to the bottom or right edge of the slide and also leave some part of the video outside (crossing the right/bottom edge)
3. Start slide show on this slide

Actual Results:
Slide zooms in or shifts (bigger the video -> bigger the shift/zoom)

Expected Results:
No shift or zoom. Even if the logic is to bring the video into the screen, slide shift opposite direction moving it even further away.

Reproducible: Always

Could reproduce. (Fedora 29, v6.1.5.2)

Strange this is for some videos, it only happens at the end of the video, for some even during playing.

Description:
Summary:
If you insert video in Impress slideshow and the video is bigger than slide or is partially out of slide, the libreoffice UI or "slideshow" breaks. See the video [1]

This bug is related to "libreoffice-gtk3" and "gstreamer1.0-gtk3". The bug does not accrue if using "libreoffice-gtk2" or none (the default LibreOffice VCL). Tested on Ubuntu 19.04. Enabled -purposed and upgraded libreoffice to "6.1.6"

Embeded video does play correctly IF the video is fully inside the slide.

If the video is a bit outside the slide or video is bigger than slide, when pressing "play" button in right pane, libreoffice UI totally breaks.
Only the ~1/8 of window display content other space is white. If resizing the window, the content gets even smaller.
Also when running the slideshow, it's broken.
I need to close impress and run it again.

The bug was initially reported Ubuntu's libreoffice bug-tracker
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1829746

[1] https://www.youtube.com/watch?v=e6UDDSBg4m8

Steps to Reproduce:
1. Open Impress
2. Insert video into slide
3. move video a outside outside the slide
4. click "play" button in side panel OR start presentation

Actual Results:
if in slide creation mode, impress UI breaks
OR
if in present mode: playback and slide is corrupted

Expected Results:
Video should be played as expected

Reproducible: Always

User Profile Reset: No

Additional Info:
I was asked by ubuntu's LO mantainers to report bug to upstream.

it seems to happen with gtk2, with gtk3 the behaviour is also wrong, but with different results

Version: 6.3.0.0.alpha1+
Build ID: e3015d7021e689c71c2ed8e5dd01a74d832c84f0
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2;
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

Also reproduced with

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 4; OS Version: Linux 4.15; UI Render: default;
Locale: ca-ES (ca_ES.UTF-8)

not reproduced with gen

@Caolán, I thought you might be interested in this issue...

I think I see the problem

Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/0c62976b4713156e93aa17b9381e010491a49a24%5E%21

tdf#124694 gtk3 GtkFixed takes the max size of all its children...

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

that solves the gtk3 version for me, a follow up for gtk2 does the same there. And backports of those are in gerrit for 6-2

Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/4f0f09f9229635aaa7b51ce45222721f035e990d%5E%21

tdf#124694 gtk2 GtkFixed takes the max size of all its children...

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Hi Caolán,
I do confirm the problem is fixed for gtk2

Version: 6.3.0.0.alpha1+
Build ID: ad7dfdef5f9504dfcd600bf4d88a97c35b9d5d6d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2;
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

but not with gtk3. I'll create a screencast

Created attachment 151785
screencast GTK3

@Caolán, do you reproduce this on your side ?

works beautifully under wayland which is my default, but under X the gtk3 one gives that problem alright.

Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/60504bffca213f6d5c66d1a2de596c20533b7d9c%5E%21

tdf#124694 gtk2 GtkFixed takes the max size of all its children...

It will be available in 6.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Hello,
Thanks for reporting this issue.
Most likely this is a duplicate of bug 124694. It has been already fixed in GTK2 and GTK3 under wayland. it needs to be fixed for under X

*** This bug has been marked as a duplicate of bug 124694 ***

*** Bug 125416 has been marked as a duplicate of this bug. ***

Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/8eff9425897a42acb3f95750a4a2654e4f428444%5E%21

tdf#124694 gtk3 GtkFixed takes the max size of all its children...

It will be available in 6.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Created attachment 152858
6.2.5 Reproducible

Unfortunately, this is still reproducible on 6.2.5.

See attachment: "6.2.5 Reproducible"

Also, in testing this, a new issue was found: https://bugs.documentfoundation.org/show_bug.cgi?id=126240

(In reply to Marcus Tomlinson from comment #14)
> Created attachment 152858 [details]
> 6.2.5 Reproducible
>
> Unfortunately, this is still reproducible on 6.2.5.
>
> See attachment: "6.2.5 Reproducible"

as mentioned in comment #10 a problem remains under X which doesn't affect wayland

Apologies Caolán! I misunderstood the impact of the subsequent patches.

Dear Caolán McNamara,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.

Dear Saren Tasciyan,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword

Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

This bug is no longer reproducible in:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 9e8c1da64fa8a520730ce0aea0f7199cd75c892f
CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded