StarlingX

CENGN build fails due to mockchain dropped from mock-1.4.20

Bug #1849147 reported by Don Penney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Critical
Don Penney

Bug Description

Brief Description
-----------------
The StarlingX build tools use mockchain, which has been deprecated. The recently released mock-1.4.20 replaced mockchain with a wrapper that calls mock --chain:
https://github.com/rpm-software-management/mock/wiki/Release-Notes-1.4.20

However, the StarlingX mockchain-parallel build tool assumes mockchain is python, and fails to determine the version of mockchain due to it being a bash script. This causes builds to fail, in new or updated build containers that have installed this new mock-1.4.20.

Severity
--------
Critical

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Build

Branch/Pull Time/Commit
-----------------------
This would impact any new or updated build container after approximately Oct 18, 2019.

Test Activity
-------------
Build

See original description
Don Penney (dpenney)
Changed in starlingx:
assignee: nobody → Don Penney (dpenney)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tools (master)

Fix proposed to branch: master
Review: https://review.opendev.org/689830

Changed in starlingx:
status: New → In Progress
Revision history for this message
Ghada Khalil (gkhalil) wrote :

Marking as stx.3.0 / critical priority since this impacts starlingx builds

Changed in starlingx:
importance: Undecided → Critical
tags: added: stx.3.0 stx.build
Don Penney (dpenney)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to root (master)

Fix proposed to branch: master
Review: https://review.opendev.org/689850

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tools (master)

Change abandoned by Don Penney (<email address hidden>) on branch: master
Review: https://review.opendev.org/689830
Reason: Abandoning in favour of https://review.opendev.org/689850

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to root (master)

Reviewed: https://review.opendev.org/689850
Committed: https://git.openstack.org/cgit/starlingx/root/commit/?id=639e435594d213709df09fcf1fb10f2d03c55094
Submitter: Zuul
Branch: master

commit 639e435594d213709df09fcf1fb10f2d03c55094
Author: Don Penney <email address hidden>
Date: Mon Oct 21 13:26:42 2019 -0400

    Update mockchain-parallel wrapper for mock-1.4.20

    The recently released mock-1.4.20 replaces mockchain with a bash
    wrapper that calls mock --chain. However, the StarlingX
    mockchain-parallel utility assumes mockchain is python, and fails to
    determine the mockchain version as a result. This causes build
    failures when mock-1.4.20 is installed.

    This update enhances mockchain-parallel to use the version from the
    installed mock rpm if the version cannot be determined from mockchain
    itself. This allows mockchain-parallel to work with mock-1.4.20, as
    well as previously supported versions of mock.

    Change-Id: Ic0360fc64e277f1816036b6259e6e51d94c7f368
    Closes-Bug: 1849147
    Signed-off-by: Don Penney <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
Ghada Khalil (gkhalil) wrote :

Adding the stx.2.0 label based on input from Don Penney that this will impact builds on the r/stx.2.0 branch. The equivalent fix will need to be cherrypicked to that branch.

tags: added: stx.2.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to root (r/stx.2.0)

Fix proposed to branch: r/stx.2.0
Review: https://review.opendev.org/689869

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to root (r/stx.2.0)

Reviewed: https://review.opendev.org/689869
Committed: https://git.openstack.org/cgit/starlingx/root/commit/?id=177fe929cddbef4318e1fe559fae7eba20b1bab0
Submitter: Zuul
Branch: r/stx.2.0

commit 177fe929cddbef4318e1fe559fae7eba20b1bab0
Author: Don Penney <email address hidden>
Date: Mon Oct 21 13:26:42 2019 -0400

    Update mockchain-parallel wrapper for mock-1.4.20

    The recently released mock-1.4.20 replaces mockchain with a bash
    wrapper that calls mock --chain. However, the StarlingX
    mockchain-parallel utility assumes mockchain is python, and fails to
    determine the mockchain version as a result. This causes build
    failures when mock-1.4.20 is installed.

    This update enhances mockchain-parallel to use the version from the
    installed mock rpm if the version cannot be determined from mockchain
    itself. This allows mockchain-parallel to work with mock-1.4.20, as
    well as previously supported versions of mock.

    Change-Id: Ic0360fc64e277f1816036b6259e6e51d94c7f368
    Closes-Bug: 1849147
    Signed-off-by: Don Penney <email address hidden>
    (cherry picked from commit 639e435594d213709df09fcf1fb10f2d03c55094)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.