Evergreen

Angular client whitescreen on Firefox

Bug #1857710 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Critical
Unassigned
Evergreen 3.4.2
3.3
Won't Fix
Critical
Unassigned

Bug Description

The Angular client whitescreens on Firefox with the following console message:

SyntaxError: invalid regular expression flag s

The culprit is the HtmlToTxt service introduced in bug 1830391, which includes a regex string replacement that uses the dotAll (/s) operator. However, dotAll, while an accepted ECMAScript proposal, is not yet supported by Firefox

Evergreen 3.4+

Revision history for this message
Galen Charlton (gmc) wrote :

A patch is available in working/user/gmcharlt/lp1857710_fix_dotall_whitescreen / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1857710_fix_dotall_whitescreen

Changed in evergreen:
milestone: none → 3.4.2
tags: added: pullrequest
Changed in evergreen:
importance: High → Critical
Revision history for this message
Jason Boyer (jboyer) wrote :

I'm annoyed that I apparently didn't load anything under /eg2/ in Firefox when testing 1830391. I've verified the breakage though, and the fix. Applying the new test sans fix does die loudly in FirefoxHeadless as one would hope. Given the simplicity of the change and the significance of the breakage I've signed off and pushed it to master and rel_3_4 to match 1830391. If 1830391 is backported to 3.3.x (which hasn't happened yet) this fix will need to follow.

Thanks Galen!

Changed in evergreen:
status: New → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.