Can delete copy that is not in ideal status without warning (Angular Edition)

Bug #1860460 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

Spun off of bug #1735566

Need to properly handle item deletion and permission overrides in the new Angular holdings delete dialog.

Bill Erickson (berick)
Changed in evergreen:
milestone: none → 3.4.2
Revision history for this message
Bill Erickson (berick) wrote :

Fixes pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1860460-copy-delete-special-status

Note this also includes general purpose (staff) permission override handling for permission failure events trapped by the network code.

Revision history for this message
Bill Erickson (berick) wrote :

For testing, follow the steps listed here, replacing copy bucket interface with the experimental catalog Holdings View interface.

https://bugs.launchpad.net/evergreen/+bug/1735566/comments/4

tags: added: pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Revision history for this message
Jennifer Weston (jweston) wrote :

Tested. Behaves as expected. The error message is clear and helpful -- "Reason(s) include: The copy in question is not in an ideal status for deleting"

I have tested this code and consent to signing off on it with my name, Jennifer Weston, and my email address, <email address hidden>.

tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Bill and Jennifer! Pushed to master and rel_3_4.

Changed in evergreen:
status: New → Fix Committed
importance: Undecided → Medium
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.