kolla-ansible

linuxbridge multiple external networks incorrect config generation

Bug #1863935 reported by bjolo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Unassigned
Ussuri
Fix Released
Medium
Unassigned
Victoria
Fix Released
Medium
Unassigned
Wallaby
Fix Committed
Medium
Unassigned
Xena
Fix Released
Medium
Unassigned

Bug Description

multiple external networks are supported by linuxbridge and OVS. Currently the config template only works for OVS. The code for linuxbridge does not loop over the bridge_name items.

#### the code for linux bridge
ubuntu@irc:~/kolla-ansible/ansible/roles/neutron/templates$ grep -B1 -n interface_mappi linuxbridge_agent.ini.j2
6-[linux_bridge]
7:physical_interface_mappings = physnet1:{{ neutron_external_interface }}

#### the code for OVS
ubuntu@irc:~/kolla-ansible/ansible/roles/neutron/templates$ grep -n -B2 -A1 bridge_mapping openvswitch_agent.ini.j2
16-[ovs]
17-{% if inventory_hostname in groups["network"] or (inventory_hostname in groups["compute"] and computes_need_external_bridge | bool ) %}
18:bridge_mappings = {% for bridge in neutron_bridge_name.split(',') %}physnet{{ loop.index0 + 1 }}:{{ bridge }}{% if not loop.last %},{% endif %}{% endfor %}
19-{% endif %}

Revision history for this message
Radosław Piliszek (yoctozepto) wrote :

Quick triage because I had this in "pending to report". Thanks for reporting this.

Changed in kolla-ansible:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/787996

Changed in kolla-ansible:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/787996
Committed: https://opendev.org/openstack/kolla-ansible/commit/24950b3894039d8f42ebaa6a6696d6a2e3d91b95
Submitter: "Zuul (22348)"
Branch: master

commit 24950b3894039d8f42ebaa6a6696d6a2e3d91b95
Author: wuchunyang <email address hidden>
Date: Mon Apr 26 21:00:58 2021 +0800

    Fix incorrect config of linuxbridge multiple external networks

    multiple external networks are supported by linuxbridge and OVS.
    Currently the config template only works for OVS

    Closes-Bug: #1863935
    Change-Id: I9da331e007c25c4a760839c566831769a68507a9

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/803273

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/803274

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/803275

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/803273
Committed: https://opendev.org/openstack/kolla-ansible/commit/f60c51d12b9d9ed22bcd120804b2939fdcbfdb4a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit f60c51d12b9d9ed22bcd120804b2939fdcbfdb4a
Author: wuchunyang <email address hidden>
Date: Mon Apr 26 21:00:58 2021 +0800

    Fix incorrect config of linuxbridge multiple external networks

    multiple external networks are supported by linuxbridge and OVS.
    Currently the config template only works for OVS

    Closes-Bug: #1863935
    Change-Id: I9da331e007c25c4a760839c566831769a68507a9
    (cherry picked from commit 24950b3894039d8f42ebaa6a6696d6a2e3d91b95)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/803274
Committed: https://opendev.org/openstack/kolla-ansible/commit/ec0687dcd596628bed2a980e680acc00e780e097
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit ec0687dcd596628bed2a980e680acc00e780e097
Author: wuchunyang <email address hidden>
Date: Mon Apr 26 21:00:58 2021 +0800

    Fix incorrect config of linuxbridge multiple external networks

    multiple external networks are supported by linuxbridge and OVS.
    Currently the config template only works for OVS

    Closes-Bug: #1863935
    Change-Id: I9da331e007c25c4a760839c566831769a68507a9
    (cherry picked from commit 24950b3894039d8f42ebaa6a6696d6a2e3d91b95)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/803275
Committed: https://opendev.org/openstack/kolla-ansible/commit/f6f2c135284fb6e82a024e84e21100da029754f4
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit f6f2c135284fb6e82a024e84e21100da029754f4
Author: wuchunyang <email address hidden>
Date: Mon Apr 26 21:00:58 2021 +0800

    Fix incorrect config of linuxbridge multiple external networks

    multiple external networks are supported by linuxbridge and OVS.
    Currently the config template only works for OVS

    Closes-Bug: #1863935
    Change-Id: I9da331e007c25c4a760839c566831769a68507a9
    (cherry picked from commit 24950b3894039d8f42ebaa6a6696d6a2e3d91b95)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 12.2.0

This issue was fixed in the openstack/kolla-ansible 12.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 13.0.0.0rc1

This issue was fixed in the openstack/kolla-ansible 13.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 10.4.0

This issue was fixed in the openstack/kolla-ansible 10.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 11.2.0

This issue was fixed in the openstack/kolla-ansible 11.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.