GNU Mailman

Attempting to subscribe to a list can throw a ValueError exception.

Bug #1878458 reported by Mark Sapiro
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNU Mailman
Fix Released
Medium
Mark Sapiro
GNU Mailman 2.1.34

Bug Description

The fix for https://bugs.launchpad.net/mailman/+bug/1859104 assumes that every entry in pending.pck is a 2-tuple, but this is wrong. The attached patch will fix this.

Related branches

lp:mailman/2.1
Revision history for this message
Mark Sapiro (msapiro) wrote :
Revision history for this message
Jim Popovitch (jimpop) wrote :

What happens if v is 1-tuple and the patch references it in "v[1].address.lower()" ?

Mark Sapiro (msapiro)
Changed in mailman:
status: In Progress → Fix Committed
Revision history for this message
Mark Sapiro (msapiro) wrote :

First of all, v is never a 1-tuple. It always is (op, *data), but even if it were a 1-tuple, op wouldn't be Pending.SUBSCRIPTION so we wouldn't look at v[1] anyway.

Revision history for this message
Jim Popovitch (jimpop) wrote :

Thanks Mark!

Revision history for this message
Mark Sapiro (msapiro) wrote :

The fix for this has been extended to apply REFUSE_SECOND_PENDING to unsubscription as well. See https://bazaar.launchpad.net/~mailman-coders/mailman/2.1/revision/1851

And yes, I know the error message says 'subscription'. This is intentional to not introduce a new i18n string.

Mark Sapiro (msapiro)
Changed in mailman:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.