Bazaar

relies on sha1 for inventories

Bug #188089 reported by Jelmer Vernooij
2
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Wishlist
Unassigned

Bug Description

bzr currently uses sha1s of the inventory everywhere. it would be nice if other algorithms would also be supported. For example, subversion provides md5 hashes.

Revision history for this message
John A Meinel (jameinel) wrote :

Any further comments on this? I know we talked about changing to just using a "validator" rather than having it explicitly be a sha1.

Changed in bzr:
importance: Undecided → Wishlist
status: New → Triaged
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

I know Robert objected to having a validator for some reason, but I can no longer remember why.

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 188089] Re: relies on sha1 for inventories

On Tue, 2008-09-30 at 14:24 +0000, Jelmer Vernooij wrote:
> I know Robert objected to having a validator for some reason, but I can
> no longer remember why.

I objected to having a 'generic validator' in a typed object.

a serialised revision is of a particular format, its already keyed by
repository format and serialiser format. in pack repositories the
validator *is* a sha1. So its about layering.

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Revision history for this message
Martin Pool (mbp) wrote :

So the bug here is that generic interfaces like eg Repository.get_inventory_sha1 should be changed to recognize that the choice of inventory validator is format-specific?

Martin Pool (mbp)
Changed in bzr:
status: Triaged → Confirmed
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.