Missing code linter support for python3.8 language features

The attachment "python-flake8_3.8.3-1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

Status changed to 'Confirmed' because the bug affects multiple users.

Sure, we can at least try to do that. pyflakes will trigger a lot of packages depending on pyflakes, so I think we get enough test coverage before we accept this package into -updates. Please make this bug report a proper SRU, and upload to package.

While full-version updates aren't usually appropriate for an SRU, I believe in this case it is the right approach.

ACK on the debdiffs in comments 3 to 5. I've uploaded them for processing by the SRU team once the packages have migrated from groovy-proposed into groovy.

Thanks!

I'm setting this to Incomplete as the packages have *not* migrated out of groovy-proposed yet.

Hello Ted, or anyone else affected,

Accepted pyflakes into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/pyflakes/2.2.0-1~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Ted, or anyone else affected,

Accepted pycodestyle into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/pycodestyle/2.6.0-1~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Ted, or anyone else affected,

Accepted python-flake8 into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-flake8/3.8.3-1~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Packages have all made it into groovy-release, marking those tasks as done and accepting the backports.

All autopkgtests for the newly accepted pycodestyle (2.6.0-1~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

ubuntu-release-upgrader/1:20.04.23 (s390x, arm64, armhf, ppc64el, amd64)
budgie-extras/1.0.2-0ubuntu1 (i386, s390x, arm64, armhf, ppc64el, amd64)
update-manager/1:20.04.10.1 (s390x, arm64, armhf, ppc64el, amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#pycodestyle

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

All autopkgtests for the newly accepted pyflakes (2.2.0-1~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

python-b2sdk/1.0.2-1 (armhf)
mu-editor/1.0.2+dfsg-4build1 (amd64)
update-manager/1:20.04.10.1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#pyflakes

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

All autopkgtests for the newly accepted python-flake8 (3.8.3-1~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

elpy/1.32.0-2 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#python-flake8

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Just to be clear: Ted and/or Marc, we need the autopkgtests fixed before accepting this into -updates. Could we please get a plan to do that? If we don't have a plan in a week or so (it doesn't need to be *done*, it just needs to be committed to) we'll need to remove these from -proposed to ensure that we don't accidentally block other updates.

I've talked with Ted; he cannot currently commit time to fixing the autopkgtest regressions, so I've removed these packages from -proposed.

All autopkgtests for the newly accepted python-flake8 (3.8.3-1~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

elpy/1.32.0-2 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#python-flake8

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

All autopkgtests for the newly accepted pyflakes (2.2.0-1~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

python-b2sdk/1.0.2-1 (armhf)
mu-editor/1.0.2+dfsg-4build1 (amd64)
update-manager/1:20.04.10.1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#pyflakes

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

All autopkgtests for the newly accepted pycodestyle (2.6.0-1~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

update-manager/1:20.04.10.1 (amd64, armhf, arm64, s390x, ppc64el)
budgie-extras/1.0.2-0ubuntu1 (amd64, armhf, arm64, s390x, ppc64el, i386)
ubuntu-release-upgrader/1:20.04.23 (amd64, armhf, arm64, s390x, ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#pycodestyle

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

The new packages were released in Groovy so I updated the status for those. The Focal tasks are still open because there wasn't an SRU.

python-flake8 has been copied back to focal-proposed.

pyflakes copied back to focal-proposed.

pycodestyle copied back to focal-proposed.

All autopkgtests for the newly accepted pyflakes (2.2.0-1~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

python-b2sdk/1.0.2-1 (armhf)
update-manager/1:20.04.10.1 (armhf)
mu-editor/1.0.2+dfsg-4build1 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#pyflakes

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

All autopkgtests for the newly accepted python-flake8 (3.8.3-1~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

elpy/1.32.0-2 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#python-flake8

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

All autopkgtests for the newly accepted pycodestyle (2.6.0-1~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

budgie-extras/1.0.2-0ubuntu1 (arm64, amd64, armhf, i386, ppc64el, s390x)
update-manager/1:20.04.10.1 (arm64, amd64, armhf, ppc64el, s390x)
ubuntu-release-upgrader/1:20.04.23 (arm64, amd64, armhf, ppc64el, s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#pycodestyle

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

New patches posted with correctly formatted changelog.

Failures:
budgie-extras/1.0.2-0ubuntu1 (arm64, amd64, armhf, i386, ppc64el, s390x)
update-manager/1:20.04.10.1 (arm64, amd64, armhf, ppc64el, s390x)
ubuntu-release-upgrader/1:20.04.23 (arm64, amd64, armhf, ppc64el, s390x)

Are all related to code style errors caught by the updated linter. These are not regressions.

Failures:
python-b2sdk/1.0.2-1 (armhf)
update-manager/1:20.04.10.1 (armhf)
mu-editor/1.0.2+dfsg-4build1 (amd64)

python-b2sdk failure is due to a segfault after its test suite has completed, not related to this update
update-manager is again the same style error as above
mu-editor appears to be a timeout, likely a transient failure

Failures:
elpy/1.32.0-2 (amd64)

Are transient (timeout in profiling), a manual re-run succeeded https://autopkgtest.ubuntu.com/packages/e/elpy/focal/amd64

The debdiffs in comments 31, 32, and 33 are equivalent to what is currently in focal-proposed, and do not need uploading. The changelog was fixed before the original debdiffs were uploaded.

Prepared related SRUs to fix test failures in other packages caused by this update:

https://bugs.launchpad.net/ubuntu/+source/budgie-extras/+bug/1907729
https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/1907727
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1907728

None of the patches were valid. They were either empty and/or against obsolete versions.

Also they all had wrong version numbers in changelog and associated release information.

We really should have backported the parser changes for 3.8, and not the entire pycodestyle. Tons of stuff has test suites that use pycodestyle and start failing on new versions.

The autopkgtest failures only tell half the story, other packages more wisely only end up running pyflakes in pep8; and pushing out a ton of SRUs like this to users when they don't actually care about them is just annoying.

Alternatively, revert the new error changes in pycodestyle/flake8 instead of patching up unrelated packages to fix breakage from the SRU and annoy users with updates they don't need.

All autopkgtests for the newly accepted pycodestyle (2.6.0-1~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

ubuntu-release-upgrader/1:20.04.23 (amd64, armhf, s390x, arm64, ppc64el)
update-manager/1:20.04.10.1 (amd64, armhf, s390x, arm64, ppc64el)
budgie-extras/1.0.2-0ubuntu1 (amd64, armhf, i386, s390x, arm64, ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#pycodestyle

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

All autopkgtests for the newly accepted pyflakes (2.2.0-1~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

update-manager/1:20.04.10.1 (armhf)
python-b2sdk/1.0.2-1 (armhf)
mu-editor/1.0.2+dfsg-4build1 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#pyflakes

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Hi,

The python3-flake8 package currently in focal-proposed depends on packages which are not in focal-proposed, and is therefore uninstallable:

The following packages have unmet dependencies:
 python3-flake8 : Depends: python3-pycodestyle (>= 2.6.0) but it is not going to be installed
                  Depends: python3-pyflakes (>= 2.2.0) but it is not going to be installed

(Note that the missing packages are new upstream versions.)

This is preventing other packages from being built against -proposed. Specifically we hit this issue when building ubuntu-advantage-tools.

As of today python-flake8 has been in focal-proposed for 292 days -- I'm not sure if uninstallable all the time, but still. If a good version of the package isn't going to be uploaded to focal-proposed anytime soon, should perhaps python-flake8 3.8.3-1~20.04.1 be pulled from focal-proposed for the moment, unblocking the builds?

Thanks!

I opened a bug for this:
https://bugs.launchpad.net/ubuntu/+source/python-flake8/+bug/1929841

The version of python-flake8 in the proposed pocket of Focal that was purported to fix this bug report has been removed because one or more bugs that were to be fixed by the upload have failed verification and been in this state for more than 10 days.