Evergreen

hold-copy map function can be fed non-unique copy lists

Bug #1886852 reported by Mike Rylander
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 3.5.1
3.4
Fix Released
Medium
Unassigned
Evergreen 3.4.4

Bug Description

Evergreen version: all since 2.12.0

The ghost of bug 1194344 returns!

We've seen in the wild some instances of action.hold_request_regen_copy_maps() receiving duplicate copies in its copy list parameter, which ends up running afoul of the copy-once-per-hold restriction on the hold-copy map table.

Branch forthcoming to prevent this from actually causing an error.

Revision history for this message
Mike Rylander (mrylander) wrote :

Branch available at: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1886852-non-unique-hold-copy-map

tags: added: pullrequest
Mike Rylander (mrylander)
Changed in evergreen:
assignee: Mike Rylander (mrylander) → nobody
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Seeing as this bug was uncovered on our training server running 3.2.10, I feel comfortable confirming this bug and targeting it to series 3.4 also.

Are we still updating 3.3? If so, this bug should be targeted at series 3.3.

Changed in evergreen:
status: New → Confirmed
Jason Stephenson (jstephenson)
Changed in evergreen:
assignee: nobody → Jason Stephenson (jstephenson)
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I have tested the function change on a pair of servers running 3.2.10 with production data, and the fix works there.

I have pushed a signoff branch in case anyone else wants to look at this as well. If not, I'll probably push the fix to master in a few days.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp-1886852-non-unique-hold-copy-map-signoff

Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
tags: added: signedoff
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 3.5.0 → 3.5.1
Revision history for this message
Jason Stephenson (jstephenson) wrote :

CW MARS has been using this patch for the past week on training and put it in production last night.

I pushed the fix to master, rel_3_5, and rel_3_4 this morning.

Thanks, Jason Etheridge and Mike Rylander!

Changed in evergreen:
status: Confirmed → Fix Committed
Jane Sandberg (sandbergja)
Changed in evergreen:
importance: Undecided → Medium
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.