Cinder

RBD: cannot reduce max clone depth setting

Bug #1901241 reported by David Hill
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Brian Rosmaita

Bug Description

RBD: cannot reduce max clone depth setting as cinder-volume raises an Exception and bails out. An operator cannot change max clone depth value from a higher value to a lower value but can from a lower value ot a higher value.

OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: nobody → David Hill (david-hill-ubisoft)
status: New → In Progress
OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: David Hill (david-hill-ubisoft) → Eric Harney (eharney)
OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: Eric Harney (eharney) → Brian Rosmaita (brian-rosmaita)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.opendev.org/759328
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=8d8d242c3924037e6774a681efabce4893a26646
Submitter: Zuul
Branch: master

commit 8d8d242c3924037e6774a681efabce4893a26646
Author: David Hill <email address hidden>
Date: Thu Oct 22 18:56:19 2020 -0400

    Do not fail when depth is greater than rbd_max_clone_depth

    Removed a sanity check in the code that raised an exception
    if the clone depth of a volume to be cloned exceeded the
    rbd_max_clone_depth config value. A consequence of this
    check was that if an operator lowered the value, volumes
    whose clone depth was greater than the new value (as would
    be allowed by the previous, higher setting) could no longer
    be cloned.

    Change-Id: I8c445058a25c2eca2fda91bdeb6befedae34ccf2
    Closes-bug: #1901241

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/760923

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/victoria)

Reviewed: https://review.opendev.org/760923
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=23a821b2a4bbb5696bc27044a455fc7837641111
Submitter: Zuul
Branch: stable/victoria

commit 23a821b2a4bbb5696bc27044a455fc7837641111
Author: David Hill <email address hidden>
Date: Thu Oct 22 18:56:19 2020 -0400

    Do not fail when depth is greater than rbd_max_clone_depth

    Removed a sanity check in the code that raised an exception
    if the clone depth of a volume to be cloned exceeded the
    rbd_max_clone_depth config value. A consequence of this
    check was that if an operator lowered the value, volumes
    whose clone depth was greater than the new value (as would
    be allowed by the previous, higher setting) could no longer
    be cloned.

    Change-Id: I8c445058a25c2eca2fda91bdeb6befedae34ccf2
    Closes-bug: #1901241
    (cherry picked from commit 8d8d242c3924037e6774a681efabce4893a26646)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/761180

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/761183

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/761184

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/ussuri)

Reviewed: https://review.opendev.org/761180
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f6e5fe187ea947fd7d4624a4f456dd7e11c35c7d
Submitter: Zuul
Branch: stable/ussuri

commit f6e5fe187ea947fd7d4624a4f456dd7e11c35c7d
Author: David Hill <email address hidden>
Date: Thu Oct 22 18:56:19 2020 -0400

    Do not fail when depth is greater than rbd_max_clone_depth

    Removed a sanity check in the code that raised an exception
    if the clone depth of a volume to be cloned exceeded the
    rbd_max_clone_depth config value. A consequence of this
    check was that if an operator lowered the value, volumes
    whose clone depth was greater than the new value (as would
    be allowed by the previous, higher setting) could no longer
    be cloned.

    Change-Id: I8c445058a25c2eca2fda91bdeb6befedae34ccf2
    Closes-bug: #1901241
    (cherry picked from commit 8d8d242c3924037e6774a681efabce4893a26646)
    (cherry picked from commit 23a821b2a4bbb5696bc27044a455fc7837641111)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 17.0.1

This issue was fixed in the openstack/cinder 17.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 16.2.1

This issue was fixed in the openstack/cinder 16.2.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 18.0.0.0b1

This issue was fixed in the openstack/cinder 18.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 15.5.0

This issue was fixed in the openstack/cinder 15.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/stein)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/761184
Committed: https://opendev.org/openstack/cinder/commit/66aad39a44cb7e4ac108624dd3c886241096c1cf
Submitter: "Zuul (22348)"
Branch: stable/stein

commit 66aad39a44cb7e4ac108624dd3c886241096c1cf
Author: David Hill <email address hidden>
Date: Thu Oct 22 18:56:19 2020 -0400

    Do not fail when depth is greater than rbd_max_clone_depth

    Removed a sanity check in the code that raised an exception
    if the clone depth of a volume to be cloned exceeded the
    rbd_max_clone_depth config value. A consequence of this
    check was that if an operator lowered the value, volumes
    whose clone depth was greater than the new value (as would
    be allowed by the previous, higher setting) could no longer
    be cloned.

    Change-Id: I8c445058a25c2eca2fda91bdeb6befedae34ccf2
    Closes-bug: #1901241
    (cherry picked from commit 8d8d242c3924037e6774a681efabce4893a26646)
    (cherry picked from commit 23a821b2a4bbb5696bc27044a455fc7837641111)
    (cherry picked from commit f6e5fe187ea947fd7d4624a4f456dd7e11c35c7d)
    (cherry picked from commit 0a3345cc0589f93e09bf55e02502e14f6e58e70e)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cinder (master)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/759536
Committed: https://opendev.org/openstack/cinder/commit/738e77a0f122dafa6d4d4f1bc538ff4e7d9f41a5
Submitter: "Zuul (22348)"
Branch: master

commit 738e77a0f122dafa6d4d4f1bc538ff4e7d9f41a5
Author: Brian Rosmaita <email address hidden>
Date: Fri Oct 23 20:13:07 2020 -0400

    Unit test RBD clone depth calculation

    Add a unit test for change I8c445058a25c

    Related-bug: #1901241
    Change-Id: If8d847245e97505f204a4d29a09aed87d1e78cb3

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder stein-eol

This issue was fixed in the openstack/cinder stein-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.