Update linux-signed/linux-restricted-modules for forward port suffixes

Bug #1904578 reported by Seth Forshee
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux-restricted-modules (Ubuntu)
Fix Released
Medium
Seth Forshee
linux-signed (Ubuntu)
Fix Released
Medium
Seth Forshee

Bug Description

Impact: When forward-porting kernels we add a +NN.NN.N suffix to the package version. We also append +N to the version for respins of linux-signed and linux-restricted-modules, which gets stripped to determine the version of kernel packages to use in the Build-Depends. The regex which strips +N does not do end-of-line matching, and so it ends up stripping part of the forward-port suffix, causing the wrong version to be placed in the Build-Depends.

Fix: Add end-of-line matching to the regex which strips the +N from the version string, ensuring that this pattern is not stripped from elsewhere in the version.

Test Case: Run 'fakeroot debian/rules clean' in a signed/l-r-m tree for a forward-port kernel and inspect debian/control. Without end-of-line matching the +NN part of +NN.NN.N is stripped from the versions in Build-Depends. With end-of-line matching it is not stripped.

Regression Potential: Any problems will result in incorrect versions placed in the Build-Depends. The most likely result is that this is a package version which does not exist, so the packages fail to build due to missing dependencies. It is very unlikely that an incorrect but valid package version in the Build-Depends, but if this did happen the packages could successfully build against the wrong kernel. This would be noticed quickly in testing as modules from linux-modules will fail to load with the packages produced from the linux-signed build.

CVE References

Seth Forshee (sforshee)
Changed in linux-restricted-modules (Ubuntu):
assignee: nobody → Seth Forshee (sforshee)
importance: Undecided → Medium
status: New → In Progress
Seth Forshee (sforshee)
Changed in linux-restricted-modules (Ubuntu):
status: In Progress → Fix Committed
Changed in linux-signed (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-signed - 5.8.0-36.40+21.04.1

---------------
linux-signed (5.8.0-36.40+21.04.1) hirsute; urgency=medium

  * Master version: 5.8.0-36.40+21.04.1

 -- Kleber Sacilotto de Souza <email address hidden> Thu, 07 Jan 2021 12:01:04 +0100

Changed in linux-signed (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-restricted-modules - 5.8.0-36.40+21.04.1

---------------
linux-restricted-modules (5.8.0-36.40+21.04.1) hirsute; urgency=medium

  * Master version: 5.8.0-36.40+21.04.1

  * Packaging resync (LP: #1786013)
    - [Packaging] resync dkms-build and family

  * CVE-2021-1052 // CVE-2021-1053
    - [Packaging] NVIDIA -- Add the 460 driver
    - [Packaging] NVIDIA -- Migrate 455 driver to 460 driver

  * Miscellaneous Ubuntu changes
    - debian/dkms-versions -- update from master

 -- Kleber Sacilotto de Souza <email address hidden> Thu, 07 Jan 2021 12:01:16 +0100

Changed in linux-restricted-modules (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.