Wishlist: Create Carousel from Item Bucket and Item Status

This would be useful for us as well. Would like to make creating Carousels as easy as possible.

Here's a branch that adds this feature: user/sandbergja/lp1906859-item-bucket-carousel

Here's a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1906859-item-bucket-carousel

And here is a test plan from the commit message:

To test carousel creation from item buckets:
    1. Create an item bucket
    2. Add a variety of items to your bucket
    3. Select all items
    4. Open the actions menu
    5. Under items, select "Create Carousel from Selected Items"
    6. Give your new carousel a name
    7. Go to Local Admin > Carousels and confirm that a carousel
    now appears.
    8. Open the record bucket for the new carousel and confirm
    that it contains all the titles for the items.

    To test carousel creation from item status:
    1. Scan items into item status
    2. Select all items
    3. Open the actions menu
    4. Select "Create Carousel from Selected Items"
    5. Repeat steps 6-8 above

Let me know what you think!

Hello, I just tested this out on https://terran-main.gapines.org/eg/opac/home and it worked as described.

But, I'm wondering one thing about the design. Is this creating a Record Bucket from the item bucket, or from item status?

I'm wondering if this meets the needs that were described. The part about "Many libraries keep Item Buckets year round of titles for Holidays, Programs, and Displays." makes me wonder if the expectation is that the Carousels would automatically pickup updates to those item buckets? But if this is making a copy in a record bucket at the time of creation, it wouldn't auto update.... I think.

I tried to edit one of the created carousels to increase the number of items and received the error:
ERROR TypeError: Cannot read properties of undefined (reading 'user')

Maybe the created carousels are not getting the user value set or something?

Josh

I also noticed that the record buckets created from items don't show up in my record bucket list. I'm not sure if that is be design, or if I'm missing something.
Josh

In response to comment #4 - this is a problem that also exists with the current function to create a carousel from a record bucket. That process creates a second (carousel) bucket based on the initial (record) bucket, so if you add an item to the initial (record) bucket afterwards it does not get picked up. It also does not show the carousel buckets in the dropdown, the only way to get to them is to go to the Carousels interface and click on the link in the Bucket column. See https://bugs.launchpad.net/evergreen/+bug/1920234 for this issue. So, although I think this usability should be improved, I don't think it should stop this from going in since it matches the behavior of the existing function.

I also tested and the only quibble I have is that when creating a carousel from a Record Bucket, the "Create Carousel from Bucket" link is on the Buckets dropdown, so my expectation would be for that link to be in the same location when creating a carousel from an Item Bucket. It took me a moment to realize that I needed to look in the actions dropdown instead and that I'd also have to select items. My preference would be to match the behavior of the Record Buckets interface and have it on the Buckets dropdown and have it automatically use all of the records in the bucket with no selection necessary.

Thanks, Josh and Terran! I added a new commit to move the item bucket's "Create Carousel from Bucket" link to make it consistent with the record bucket link.

I force-pushed a rebase to this branch today.

Tested on terran-testbox.gapines.org - I love this feature!

I will note that it is running into longstanding preexisting bug 1485695 (see for example bucket 13 / Test Carousel 4 on the above test server). What this means if that a user adds more than 1 item per bib to the carousel, the carousel's bucket will show the duplicate count (but a single line item) and the carousel itself will show the book jacket twice.

However, I don't consider that a blocker here since it's a known issue.

I consent to signing off on this with my name, Andrea Buntz Neiman, and my email address <email address hidden>

Jane, could you please write a quick release note for this? It will be great to get this into 3.12!

Thanks for catching that, Terran! Rebased and added a release note to the same branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1906859-item-bucket-carousel

I gave this another test and it's not actually working right for me. The mechanism to create a new carousel is working, but it is adding the wrong records to the record bucket that it creates.

My test:
1. Created an item bucket
2. Added 3 items (various Neil Gaiman titles) individually to bucket
3. Verified that the items were in the bucket
4. Used the Create Carousel from Bucket option on the item buckets page
5. Verified that a new carousel was created with the name I gave it
6. Made it visible in the OPAC and it was showing the wrong records
7. Clicked the link in the carousel interface to open the related record bucket and saw that the 3 records that had been added were record IDs 1, 2, and 3.

Thanks for catching that bug, Terran! I fixed it in a fourth commit on the newly rebased branch user/sandbergja/lp1906859-item-bucket-carousel-2 / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1906859-item-bucket-carousel-2

I think it's ready for further testing.

I looked at this on https://terran-main.gapines.org/ - I can see the option to Create Carousel from Selected Items in Item status and Create Carousel from Bucket in the item buckets interface, but nothing happens when I select it in Buckets, and in item status it's greyed out.
I'll also note that it might be more at home in the Actions menu for Buckets instead of the bucket selector?

My install script didn't copy a necessary file into place - it's there now and the Create Carousel action is now working so can be tested.

The reason it is under the bucket selector is for consistency with the similar action in the record buckets. Regardless of which dropdown they are under, they should be consistent with each other.

Excellent!
That note about the which dropdown the action appears in makes sense.

I was able to create carousels from both item status and item buckets, and I was also able to add additional items to the carousel by putting them into the system-generated record bucket.

I consent to signing off on this with my name, Katie Greenleaf Martin, and my email address <email address hidden>

Fix committed during Monday Code Review Party