Add Emacs mode to fm_IDL.xml

Bug #1914625 reported by Jason Stephenson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Developers using Emacs would benefit from a mode added to the bottom of the fm_IDL.xml file. There is already a directive for vim, so this is just an expansion of what is already there.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

I've pushed a commit to the working repository that adds the Emacs file mode variables to the fm_IDL.xml to use the same configuration as the vim mode.

This commit also tabifies the fm_IDL.xml files to match the configuration.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1914625-add-emacs-mode-IDL

tags: added: pullrequest
Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
milestone: none → 3.7-beta
Changed in evergreen:
milestone: 3.7-beta → 3.8-beta
Changed in evergreen:
milestone: 3.8-beta → 3.next
Revision history for this message
Jason Boyer (jboyer) wrote :

I don't have anything against the idea (there seems to be a surprisingly large preference for vim in the Eg community) but there are 2 problems as it's implemented currently.

First, vi/m modelines are only looked for in the first or last few lines. (I've seen reference to 5 lines but haven't found a definitive answer for modern vim's), so as-written this would stop the vim modeline from being working. Depending on how many lines into a file emacs will look for local variables they could be placed above the vim modeline or worst case, vim could have the top and emacs the bottom, or vice-versa.

Additionally, while I agree that consistent tab/space-ification for fm_IDL.xml is a good goal, it should be a separate commit from any other changes.

tags: removed: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Following up on Jason Boyer's comment, I have made the changes that he suggested:

Moved the vim mode to the bottom of the file and separated the indentation commit from the mode commit.

I also rebased the branch on master before doing the re-indentation.

I have force-pushed to the same location.

tags: added: pullrequest
Changed in evergreen:
assignee: nobody → Josh Stompro (u-launchpad-stompro-org)
Revision history for this message
Galen Charlton (gmc) wrote :

While I have no objection to adding the Emacs modeline, I am -1 to the proposed indentation patch: it removes useful indentation of the SQL statements in the virtual IDL classes.

Revision history for this message
Jason Stephenson (jstephenson) wrote (last edit ):

Not that I think it is all that urgent to add this, I have pushed a rebased branch that drops the top commit, so this only has the commit to add the Emacs mode comments:

user/dyrcona/lp1914625-add-emacs-mode-IDL-noindent https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1914625-add-emacs-mode-IDL-noindent

I thought this would be nice to have for the few of us that use GNU Emacs.

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Hello, I'm working on testing this, but the indent change commit isn't applying to master cleanly right now. I'll test the first commit for now.
Josh

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Ha, I need to remember to refresh the page before commenting.

I've tested just the adding of the emacs variables and can confirm that the vim and emacs settings work just fine.

Signoff working branch at: user/stompro/lp1914625-add-emacs-mode-IDL-noindent-signoff

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1914625-add-emacs-mode-IDL-noindent-signoff

Josh

tags: added: signedoff
Changed in evergreen:
assignee: Josh Stompro (u-launchpad-stompro-org) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed the Emacs mode patch to master for inclusion in 3.11-beta. Thanks, Jason and Josh!

Changed in evergreen:
status: New → Confirmed
milestone: 3.next → 3.11-beta
assignee: nobody → Galen Charlton (gmc)
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.