Intel e1000e blocks the system to enter PC10 on TGL platform

Bug #1919116 reported by AceLan Kao
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
Fix Released
Undecided
Unassigned
linux (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Invalid
Undecided
Unassigned
Hirsute
Fix Released
Undecided
AceLan Kao
Impish
Invalid
Undecided
Unassigned
linux-oem-5.10 (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Fix Released
Undecided
AceLan Kao
Hirsute
Invalid
Undecided
Unassigned
Impish
Invalid
Undecided
Unassigned
linux-oem-5.13 (Ubuntu)
Focal
Invalid
Undecided
Unassigned
Hirsute
Invalid
Undecided
Unassigned
Impish
Invalid
Undecided
Unassigned

Bug Description

[Impact]
The deepest package cstate is PC9 and fails to enter low power mode during s2i on Tiger Lake platform.

[Fix]
Intel provides a fix for TGL platform
https://patchwork.kernel.org/project<email address hidden>/

[Test]
Verified on Dell TGL platforms and it works as expected.

[Where problem could occur]
It actually adds a quirk for tgl platform to ignore Latency Tolerance Reporting (LTR) in pmc_core driver, that makes GBE on TGL won't block the system to enter deeper PC state. It should be safe for all TGL platforms.

[Misc]
Currently, this commit is not accepted and a v2 is expected. So, submit this commit to oem kernel only and will revert it and submit final version of this patch to ubuntu kernels later.

AceLan Kao (acelankao)
Changed in linux-oem-5.10 (Ubuntu Focal):
assignee: nobody → AceLan Kao (acelankao)
Changed in linux-oem-5.10 (Ubuntu):
status: New → Invalid
tags: added: oem-priority originate-from-1913281 somerville
AceLan Kao (acelankao)
Changed in linux-oem-5.10 (Ubuntu Focal):
status: New → In Progress
AceLan Kao (acelankao)
description: updated
description: updated
summary: - Intel e1000e blocks the system to enter PC10
+ Intel e1000e blocks the system to enter PC10 on TGL platform
Timo Aaltonen (tjaalton)
Changed in linux-oem-5.10 (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
AceLan Kao (acelankao)
tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-oem-5.10 - 5.10.0-1021.22

---------------
linux-oem-5.10 (5.10.0-1021.22) focal; urgency=medium

  * focal/linux-oem-5.10: 5.10.0-1021.22 -proposed tracker (LP: #1922921)

  * Display abnormal on the TGL+4k panel machines (LP: #1922885)
    - drm/i915/display: Do not allow DC3CO if PSR SF is enabled
    - SAUCE: drm/i915/display/psr: Disable DC3CO when the PSR2 is used

  * Fix mic on P620 after S3 resume (LP: #1921757)
    - ALSA: usb-audio: Carve out connector value checking into a helper
    - ALSA: usb-audio: Check connector value on resume

 -- Timo Aaltonen <email address hidden> Wed, 07 Apr 2021 18:07:55 +0300

Changed in linux-oem-5.10 (Ubuntu Focal):
status: Fix Committed → Fix Released
Changed in linux-oem-5.13 (Ubuntu Impish):
status: New → Invalid
Revision history for this message
AceLan Kao (acelankao) wrote :

The upstream patch is here.

commit d1635448f1105e549b4041aab930dbc6945fc635 (tag: platform-drivers-x86-v5.12-2)
Author: David E. Box <email address hidden>
Date: Fri Mar 19 13:18:44 2021 -0700

    platform/x86: intel_pmc_core: Ignore GBE LTR on Tiger Lake platforms

    Due to a HW limitation, the Latency Tolerance Reporting (LTR) value
    programmed in the Tiger Lake GBE controller is not large enough to allow
    the platform to enter Package C10, which in turn prevents the platform from
    achieving its low power target during suspend-to-idle. Ignore the GBE LTR
    value on Tiger Lake. LTR ignore functionality is currently performed solely
    by a debugfs write call. Split out the LTR code into its own function that
    can be called by both the debugfs writer and by this work around.

    Signed-off-by: David E. Box <email address hidden>
    Reviewed-by: Sasha Neftin <email address hidden>
    Cc: <email address hidden>
    Reviewed-by: Rajneesh Bhardwaj <email address hidden>
    Link: https://<email address hidden>
    Signed-off-by: Hans de Goede <email address hidden>

Changed in linux-oem-5.13 (Ubuntu Focal):
status: New → Invalid
Changed in linux (Ubuntu Focal):
status: New → Invalid
Changed in linux (Ubuntu Hirsute):
status: New → In Progress
Changed in linux (Ubuntu Impish):
status: New → Invalid
AceLan Kao (acelankao)
Changed in linux (Ubuntu Hirsute):
assignee: nobody → AceLan Kao (acelankao)
Changed in linux-oem-5.10 (Ubuntu Hirsute):
status: New → Invalid
no longer affects: linux-oem-5.13 (Ubuntu)
Changed in linux-oem-5.13 (Ubuntu Hirsute):
status: New → Invalid
Revision history for this message
AceLan Kao (acelankao) wrote :

Hirsute got this fixed through stable update since Ubuntu-5.11.0-18.19

Changed in linux (Ubuntu Hirsute):
status: In Progress → Fix Released
Changed in hwe-next:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.