[22.04 FEAT] smc: Add User-defined EID (Enterprise ID) Support - kernel

Bug #1929060 reported by bugproxy
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu on IBM z Systems
Fix Released
High
Skipper Bug Screeners
linux (Ubuntu)
Fix Released
Undecided
Canonical Kernel Team

Bug Description

Add a tool, tentatively titled smc_eid, to display and set EIDs. Should indicate SEIDs as such.
Notes:
* EIDs are uppercase only - we should silently convert to all uppercase
* Check latest SLD for valid special characters.
* Make sure only authorized users are allowed to modify EIDs - reading is OK for everybody, but writing requires authorization.
* SEIDs can be disabled, but (obviously) not set.
* EID config must be available on module load.
* zOS sets the UEIDs globally, i.e. not separate SMC-D and SMC-R.

Business Case: Required for users that need to strictly separate/prevent certain OS images from utilizing ISM devices for communication (Security). Furthermore, z/OS disables SEID per default, and will likely have users utilize fine-grained EIDs. Hence we need to be able to support UEIDs for compatibility.

This feature is for the kernel part.

bugproxy (bugproxy)
tags: added: architecture-s39064 bugnameltc-192732 severity-high targetmilestone-inin2110
Changed in ubuntu:
assignee: nobody → Skipper Bug Screeners (skipper-screen-team)
affects: ubuntu → linux (Ubuntu)
Revision history for this message
Frank Heimes (fheimes) wrote :

@IBM Which is the target kernel this will land at?

Changed in ubuntu-z-systems:
assignee: nobody → Skipper Bug Screeners (skipper-screen-team)
Changed in linux (Ubuntu):
assignee: Skipper Bug Screeners (skipper-screen-team) → nobody
Changed in ubuntu-z-systems:
importance: Undecided → High
status: New → Incomplete
Changed in linux (Ubuntu):
status: New → Incomplete
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2021-08-04 11:32 EDT-------
Feature will not make it in time for Impish/21.10, therefore moving to U22.04

tags: added: targetmilestone-inin2204
removed: targetmilestone-inin2110
Frank Heimes (fheimes)
summary: - [21.10 FEAT] smc: Add User-defined EID (Enterprise ID) Support - kernel
+ [22.04 FEAT] smc: Add User-defined EID (Enterprise ID) Support - kernel
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for linux (Ubuntu) because there has been no activity for 60 days.]

Changed in linux (Ubuntu):
status: Incomplete → Expired
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2022-03-15 18:19 EDT-------
Upstream with kernel 5.16:

# fa0866625543 ("net/smc: add support for user defined EIDs")
# 11a26c59fc51 ("net/smc: keep static copy of system EID")
# 3c572145c24e ("net/smc: add generic netlink support for system EID")

Revision history for this message
Frank Heimes (fheimes) wrote (last edit ):

Thanks for the commits.
I'm able to cherry pick them cleanly to jammy master-next.

A build of a patched jammy kernel 5.15.0-23.23~lp1929060 is currently ongoing at PPA:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1929060/+packages
and is soon available for testing.

Changed in linux (Ubuntu):
status: Expired → New
Changed in ubuntu-z-systems:
status: Incomplete → New
Revision history for this message
Frank Heimes (fheimes) wrote :

Patch request submitted:
https://lists.ubuntu.com/archives/kernel-team/2022-March/thread.html#128697
Updating status to 'In Progress'.

Changed in linux (Ubuntu):
status: New → In Progress
Changed in ubuntu-z-systems:
status: New → In Progress
Changed in linux (Ubuntu):
assignee: nobody → Canonical Kernel Team (canonical-kernel-team)
information type: Private → Public
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2022-03-16 13:22 EDT-------
(In reply to comment #11)
> Patch request submitted:
> https://lists.ubuntu.com/archives/kernel-team/2022-March/thread.html#128697
> Updating status to 'In Progress'.

Same as Bug 192590, pls don't just cherry-pick the certain patches mentioned above. All of the smc related patches till the date 2021-10-28 on the list (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/net/smc?h=v5.16) should be taken for U22.04

Revision history for this message
Frank Heimes (fheimes) wrote :

Hi WEZH, well if commits are provided here, we expect that they make up the functionality described by the title and bug description, and can be taken as they are (cherry-picked) - and in case not a backport would be needed.

We cannot just (kind of blindly) pick all the commits up to a certain date - it's (very) unlikely that this will be acceptable by our kernel team (who reviews all submissions in detail).

What's required (for a patch here, or for an sru) is a minimal set of patches that make up a logical functional unit (like here at the title: "Add User-defined EID (Enterprise ID) Support").
The code also needs to be upstream accepted (that's the case here) and in case of s390x code, it needs to be signed-off by you (actually by IBM, at the commit level - as usual), pre-tested - there must be confidence about the patch set - and the willingness to help maintaining it.

Please notice that we discuss adding code to an upcoming LTS release that will need to be supported by up to 10 years.

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-hwe-5.15/5.15.0-25.25~20.04.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Frank Heimes (fheimes) wrote :

This feature was request for 22.04, hence the hwe kernel is more a fall out.
Hence updating tag to unblock the process.

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 5.15.0-25.25

---------------
linux (5.15.0-25.25) jammy; urgency=medium

  * jammy/linux: 5.15.0-25.25 -proposed tracker (LP: #1967146)

  * Miscellaneous Ubuntu changes
    - SAUCE: Revert "scsi: core: Reallocate device's budget map on queue depth
      change"

 -- Paolo Pisati <email address hidden> Wed, 30 Mar 2022 17:28:11 +0200

Changed in linux (Ubuntu):
status: In Progress → Fix Released
Frank Heimes (fheimes)
Changed in ubuntu-z-systems:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.