Evergreen

Hidden search result title

Bug #1930933 reported by Bob Wicksall
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
Evergreen 3.7.1
3.5
Fix Released
High
Unassigned
Evergreen 3.5.5
3.6
Fix Released
High
Unassigned
Evergreen 3.6.4

Bug Description

After applying the fix for LP 1902965 we notice that items with the word "Hidden" in the title are displayed with a hidden/invisible title in the results table.

Example: The hidden folk : stories of fairies, gnomes, selkies, and other hidden folk

in /opac/parts/result/table.tt2 around line 194:

[% html_text_attr('title', l('Display record details for "[_1]"', attrs.title)) | html%]>

The "| html" is mangling the title display and leaking "hidden".

Would something like the following be an appropriate fix?

[%-
   filtered_title = attrs.title | html;
-%]
[% html_text_attr('title', l('Display record details for "[_1]"', filtered_title)) %]>

Revision history for this message
Bob Wicksall (bwicksall) wrote :

This bug also results in broken tool tips when hovering over a title.

You Get:

   "Display

Instead of:

   Display record details for "Woodland folk tales"

Revision history for this message
Bob Wicksall (bwicksall) wrote :

More detail. Titles that start with Hidden are fine. So "Hidden summit" is fine but "The hidden" is hidden.

The Title attribute on Place Hold is also broken. Hover over the place hold button and you will see:

   "Place

Revision history for this message
Lindsay Stratton (lstratton) wrote :

This appears to affect titles starting with articles and prepositions - a, the, at, etc.

For example - "Among the hidden", "Treasures long hidden" display correctly whereas "A hidden truth", "At hidden falls", "The hidden oasis" do not.

Jennifer Pringle (jpringle-u)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Bob Wicksall (bwicksall) wrote :

I have a heavily modified OPAC but I applied the following in my environment:

http://git.pls-net.org/gitweb/?p=templates_owwl.git;a=commitdiff;h=f20afc0b12b9865831d5fbe95fb168747adc83be

Basically I filter the title once and then use filtered_title whenever necessary.

Revision history for this message
Galen Charlton (gmc) wrote :

I've pushed a patch that takes a different approach:

working/user/gmcharlt/lp1930933_reveal_what_was_hidden / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1930933_reveal_what_was_hidden

Changed in evergreen:
milestone: none → 3.7.1
tags: added: opac regression
Changed in evergreen:
importance: Undecided → High
tags: added: pullrequest
Jason Stephenson (jstephenson)
Changed in evergreen:
assignee: nobody → Jason Stephenson (jstephenson)
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I have tested Galen's patch and added my signoff at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/dyrcona/lp1930933_reveal_what_was_hidden

What I did to test was to edit 2 Vivaldi records in the concerto database. I changed "6 Concertos" title to "The Hidden Concertos" and then modified "Vivaldi, The Four Seasons" to "<script>alert('look out');</script> The Four Seasons."

Before applying Galen's patch the title of "The Hidden Concertos" was hidden in both the bootstrap OPAC and the traditional OPAC.

After applying Galen's patch, the title showed.

In neither case did an alert pop up for "The Four Seasons."

Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
Galen Charlton (gmc)
tags: added: signedoff
Jeff Davis (jdavis-sitka)
Changed in evergreen:
assignee: nobody → Jeff Davis (jdavis-sitka)
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Galen's patch fixes the reported issue for me too. Pushed to rel_3_6 through master, and pushed the TPAC part to rel_3_5 as well. Thanks all!

Changed in evergreen:
assignee: Jeff Davis (jdavis-sitka) → nobody
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.