Get container_facts failing on localhost

Bug #1933347 reported by Michal Arbet
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
High
Unassigned

Bug Description

Hi,

Kolla-ansible is trying to check container_facts, but python docker library is not installed on localhost (deployment host) by default.

TASK [prechecks : Checking host OS release or version] ************************************************************************************************************************************************************
skipping: [ceph0]
skipping: [ceph1]
skipping: [ceph2]
skipping: [localhost]
skipping: [controller0]
skipping: [controller1]
skipping: [compute0]
skipping: [compute1]

TASK [prechecks : include_tasks] **********************************************************************************************************************************************************************************
included: /opt/kolla-ansible/ansible/roles/prechecks/tasks/timesync_checks.yml for ceph0, ceph1, ceph2, localhost, controller0, controller1, compute0, compute1

TASK [prechecks : Get container facts] ****************************************************************************************************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ModuleNotFoundError: No module named 'docker'
fatal: [localhost]: FAILED! => {"changed": false, "module_stderr": "Traceback (most recent call last):\n File \"/home/ubuntu/.ansible/tmp/ansible-tmp-1624454249.8777878-29781-115946227316597/AnsiballZ_kolla_container_facts.py\", line 102, in <module>\n _ansiballz_main()\n File \"/home/ubuntu/.ansible/tmp/ansible-tmp-1624454249.8777878-29781-115946227316597/AnsiballZ_kolla_container_facts.py\", line 94, in _ansiballz_main\n invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n File \"/home/ubuntu/.ansible/tmp/ansible-tmp-1624454249.8777878-29781-115946227316597/AnsiballZ_kolla_container_facts.py\", line 40, in invoke_module\n runpy.run_module(mod_name='ansible.modules.kolla_container_facts', init_globals=None, run_name='__main__', alter_sys=True)\n File \"/usr/lib/python3.8/runpy.py\", line 207, in run_module\n return _run_module_code(code, init_globals, run_name, mod_spec)\n File \"/usr/lib/python3.8/runpy.py\", line 97, in _run_module_code\n _run_code(code, mod_globals, init_globals,\n File \"/usr/lib/python3.8/runpy.py\", line 87, in _run_code\n exec(code, run_globals)\n File \"/tmp/ansible_kolla_container_facts_payload_8sraqpzw/ansible_kolla_container_facts_payload.zip/ansible/modules/kolla_container_facts.py\", line 18, in <module>\nModuleNotFoundError: No module named 'docker'\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)
Changed in kolla-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/797584

Changed in kolla-ansible:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/797646
Committed: https://opendev.org/openstack/kolla-ansible/commit/281c9935da076eb7a744136e3738084468692278
Submitter: "Zuul (22348)"
Branch: master

commit 281c9935da076eb7a744136e3738084468692278
Author: Michal Arbet <email address hidden>
Date: Wed Jun 23 15:28:04 2021 +0200

    Do not run timesync checks on deployment host

    Kolla-ansible install python docker library in role/baremetal
    to group/baremetal, because of this get container facts
    for timesync checks is failing on deployment host.

    This patch adding when conditional, so deployment host
    will be skipped as there is no need to run timesync
    checks.

    Closes-Bug: #1933347
    Change-Id: Ifefb9c74ee6a80cdbc458992d0196850ddfe7ffa

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kolla-ansible (stable/wallaby)

Change abandoned by "Michal Arbet <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/797584
Reason: Duplicate

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by "Michal Arbet <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/797584
Reason: abandon

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/803555

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/797584
Committed: https://opendev.org/openstack/kolla-ansible/commit/b6d8eefb8ea934dccd3cbeeb15d5d0d8e18fca68
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit b6d8eefb8ea934dccd3cbeeb15d5d0d8e18fca68
Author: Michal Arbet <email address hidden>
Date: Wed Jun 23 15:28:04 2021 +0200

    Do not run timesync checks on deployment host

    Kolla-ansible install python docker library in role/baremetal
    to group/baremetal, because of this get container facts
    for timesync checks is failing on deployment host.

    This patch adding when conditional, so deployment host
    will be skipped as there is no need to run timesync
    checks.

    Closes-Bug: #1933347
    Change-Id: Ifefb9c74ee6a80cdbc458992d0196850ddfe7ffa
    (cherry picked from commit 281c9935da076eb7a744136e3738084468692278)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/803555
Committed: https://opendev.org/openstack/kolla-ansible/commit/0a11cb0b8bc945d1d041fd7e158bf0a2345aa846
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 0a11cb0b8bc945d1d041fd7e158bf0a2345aa846
Author: Michal Arbet <email address hidden>
Date: Wed Jun 23 15:28:04 2021 +0200

    Do not run timesync checks on deployment host

    Kolla-ansible install python docker library in role/baremetal
    to group/baremetal, because of this get container facts
    for timesync checks is failing on deployment host.

    This patch adding when conditional, so deployment host
    will be skipped as there is no need to run timesync
    checks.

    Closes-Bug: #1933347
    Change-Id: Ifefb9c74ee6a80cdbc458992d0196850ddfe7ffa
    (cherry picked from commit 281c9935da076eb7a744136e3738084468692278)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 12.2.0

This issue was fixed in the openstack/kolla-ansible 12.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 13.0.0.0rc1

This issue was fixed in the openstack/kolla-ansible 13.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 11.2.0

This issue was fixed in the openstack/kolla-ansible 11.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.