Internal Server Error when Staff Places Hold in Traditional Catalog using Patron Barcode Completion

Bug #1965317 reported by Michele Morgan
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
3.7
Fix Released
High
Unassigned

Bug Description

Evergreen 3.8

With patron barcode completion configured, using a partial barcode to retrieve the patron on the Traditional Catalog Place Holds screen results in an ISE. This is true whether either the Bootstrap OPAC or the TPAC is set as the Traditional Catalog.

Steps to reproduce on a Concerto system:

Enter a patron barcode completion configuration:

Administration->Local Administration->Barcode Completion

Enter a new configuration as follows:

Active: TRUE
Applies to Items: FALSE
Applies to Users: TRUE
Length: 11
Owner: CONS
Padding: 0
Padding At End: FALSE
Prefix: 99999

Go to Checkout and confirm that entering 376864 retrieves the correct patron (Leon Anderson)

Place a hold for patron 99999376864 as follows:

Cataloging->Search the Catalog (Traditional)

Find a record, click Place Hold

Enter 376864 as the patron barcode, note that the patron info populates.

Supply a valid pickup location

Click Submit

This results in an Internal Server Error.

Revision history for this message
Dan Briem (dbriem) wrote :

Branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp1965317_barcode_completion_on_tpac_staff_holds

The completed barcode loads in the barcode input if the hold group radio input exists and is unchecked. This branch changes that to: doesn't exist or is unchecked (the hold group interface isn't rendered if there are no hold groups in the system).

Changed in evergreen:
status: New → Confirmed
tags: added: pullrequest
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.8.1
Revision history for this message
Michele Morgan (mmorgan) wrote :

This did not work for me on the bug squashing week community test server, but I applied it to a local test server and my traditional catalog hold using patron barcode completion was placed successfully with no ISE. Tested with both TPAC and BOOPAC set as the traditional staff catalog.

My signoff is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1965317_barcode_completion_on_tpac_staff_holds-signoff

user/mmorgan/lp1965317_barcode_completion_on_tpac_staff_holds-signoff

tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Nice work, Dan and Michele! Pushed to 3.8 and above. Since 3.7 reached its end of life last week (https://wiki.evergreen-ils.org/doku.php?id=dev:release_process:schedule), I set it as Won't Fix.

Changed in evergreen:
importance: Undecided → High
status: Confirmed → Fix Committed
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I am inclined to override the "3.7 reached its end of life last week" part and have this pushed to 3.7. We really ought to do another 3.7 release, since we've only managed two. There are a ton of patches added to 3.7 since the most recent release.

That said, we need to either get our act together as a community, or just give up on bug fix releases.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

I have pushed the patch to rel_3_7. Hopefully we can get 1 more 3.7 relase out the door before the conference in June.

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.