Update OS policy capability handshake

Bug #1966089 reported by Colin Ian King
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
Fix Released
Undecided
Unassigned
linux (Ubuntu)
Fix Released
High
Andrea Righi
Focal
Invalid
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned
Kinetic
Fix Released
Undecided
Unassigned
linux-oem-5.14 (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Fix Released
Undecided
koba
Jammy
Invalid
Undecided
Unassigned
Kinetic
Invalid
Undecided
Unassigned
linux-oem-5.17 (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Invalid
Undecided
Unassigned
Jammy
Fix Released
Undecided
koba
Kinetic
Invalid
Undecided
Unassigned

Bug Description

== SRU JAMMY ==

Update int340x OS policy capability handshake; required for full functionality in thermald 2.4.9 to improve functionality for newer H/W.

== The fix ==

Upstream commit:

commit c7ff29763989bd09c433f73fae3c1e1c15d9cda4
Author: Srinivas Pandruvada <email address hidden>
Date: Mon Mar 14 15:09:37 2022 -0700

    thermal: int340x: Update OS policy capability handshake

    Update the firmware with OS supported policies mask, so that firmware can
    relinquish its internal controls. Without this update several Tiger Lake
    laptops gets performance limited with in few seconds of executing in
    turbo region.

    The existing way of enumerating firmware policies via IDSP method and
    selecting policy by directly writing those policy UUIDS via _OSC method
    is not supported in newer generation of hardware.

    There is a new UUID "B23BA85D-C8B7-3542-88DE-8DE2FFCFD698" is defined for
    updating policy capabilities. As part of ACPI _OSC method:

    Arg0 - UUID: B23BA85D-C8B7-3542-88DE-8DE2FFCFD698
    Arg1 - Rev ID: 1
    Arg2 - Count: 2
    Arg3 - Capability buffers: Array of Arg2 DWORDS

    DWORD1: As defined in the ACPI 5.0 Specification
    - Bit 0: Query Flag
    - Bits 1-3: Always 0
    - Bits 4-31: Reserved

    DWORD2 and beyond:
    - Bit0: set to 1 to indicate Intel(R) Dynamic Tuning is active, 0 to
    indicate it is disabled and legacy thermal mechanism should
    be enabled.
    - Bit1: set to 1 to indicate Intel(R) Dynamic Tuning is controlling
    active cooling, 0 to indicate bios shall enable legacy thermal
    zone with active trip point.
    - Bit2: set to 1 to indicate Intel(R) Dynamic Tuning is controlling
    passive cooling, 0 to indicate bios shall enable legacy thermal
    zone with passive trip point.
    - Bit3: set to 1 to indicate Intel(R) Dynamic Tuning is handling
    critical trip point, 0 to indicate bios shall enable legacy
    thermal zone with critical trip point.
    - Bits 4:31: Reserved

    From sysfs interface, there is an existing interface to update policy
    UUID using attribute "current_uuid". User space can write the same UUID
    for ACTIVE, PASSIVE and CRITICAL policy. Driver converts these UUIDs to
    DWORD2 Bit 1 to Bit 3. When any of the policy is activated by user
    space it is assumed that dynamic tuning is active.

    For example
    $cd /sys/bus/platform/devices/INTC1040:00/uuids
    To support active policy
    $echo "3A95C389-E4B8-4629-A526-C52C88626BAE" > current_uuid
    To support passive policy
    $echo "42A441D6-AE6A-462b-A84B-4A8CE79027D3" > current_uuid
    To support critical policy
    $echo "97C68AE7-15FA-499c-B8C9-5DA81D606E0A" > current_uuid

    To check all the supported policies
    $cat current_uuid
    3A95C389-E4B8-4629-A526-C52C88626BAE
    42A441D6-AE6A-462b-A84B-4A8CE79027D3
    97C68AE7-15FA-499c-B8C9-5DA81D606E0A

    To match the bit format for DWORD2, rearranged enum int3400_thermal_uuid
    and int3400_thermal_uuids[] by swapping current INT3400_THERMAL_ACTIVE
    and INT3400_THERMAL_PASSIVE_1.

    If the policies are enumerated via IDSP method then legacy method is
    used, if not the new method is used to update policy support.

    Signed-off-by: Srinivas Pandruvada <email address hidden>
    Signed-off-by: Rafael J. Wysocki <email address hidden>

CVE References

Revision history for this message
Colin Ian King (colin-king) wrote :

This fix was requested by the thermald developer Srinivas Pandruvada to support the new version of thermald.

Changed in linux (Ubuntu):
importance: Undecided → High
assignee: nobody → Andrea Righi (arighi)
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1966089

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Revision history for this message
Colin Ian King (colin-king) wrote :
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-hwe-5.15/5.15.0-25.25~20.04.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 5.15.0-25.25

---------------
linux (5.15.0-25.25) jammy; urgency=medium

  * jammy/linux: 5.15.0-25.25 -proposed tracker (LP: #1967146)

  * Miscellaneous Ubuntu changes
    - SAUCE: Revert "scsi: core: Reallocate device's budget map on queue depth
      change"

 -- Paolo Pisati <email address hidden> Wed, 30 Mar 2022 17:28:11 +0200

Changed in linux (Ubuntu):
status: Incomplete → Fix Released
koba (kobako)
Changed in linux-oem-5.14 (Ubuntu Focal):
status: New → In Progress
assignee: nobody → koba (kobako)
Revision history for this message
koba (kobako) wrote :
Changed in linux-oem-5.17 (Ubuntu Jammy):
status: New → In Progress
assignee: nobody → koba (kobako)
koba (kobako)
tags: added: oem-priority originate-from-1965785 somerville
Timo Aaltonen (tjaalton)
Changed in linux-oem-5.17 (Ubuntu Focal):
status: New → Invalid
Changed in linux-oem-5.17 (Ubuntu Jammy):
status: In Progress → Fix Committed
Changed in linux-oem-5.14 (Ubuntu Focal):
status: In Progress → Fix Committed
Changed in linux-oem-5.14 (Ubuntu Jammy):
status: New → Invalid
Changed in linux-oem-5.14 (Ubuntu):
status: New → Invalid
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-oem-5.17/5.17.0-1006.6 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-jammy
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

missing verification for oem-5.14

koba (kobako)
tags: added: verification-done-focal verification-done-jammy
removed: verification-needed-focal verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-oem-5.17 - 5.17.0-1011.12

---------------
linux-oem-5.17 (5.17.0-1011.12) jammy; urgency=medium

  * CVE-2022-1972
    - netfilter: nf_tables: sanitize nft_set_desc_concat_parse()

  * CVE-2022-1966
    - netfilter: nf_tables: disallow non-stateful expression in sets earlier

 -- Thadeu Lima de Souza Cascardo <email address hidden> Fri, 03 Jun 2022 14:17:23 -0300

Changed in linux-oem-5.17 (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-oem-5.14 - 5.14.0-1042.47

---------------
linux-oem-5.14 (5.14.0-1042.47) focal; urgency=medium

  * CVE-2022-1972
    - netfilter: nf_tables: sanitize nft_set_desc_concat_parse()

  * CVE-2022-1966
    - netfilter: nf_tables: disallow non-stateful expression in sets earlier

 -- Thadeu Lima de Souza Cascardo <email address hidden> Fri, 03 Jun 2022 15:00:01 -0300

Changed in linux-oem-5.14 (Ubuntu Focal):
status: Fix Committed → Fix Released
Timo Aaltonen (tjaalton)
Changed in linux (Ubuntu Jammy):
status: New → Fix Released
Changed in linux (Ubuntu Focal):
status: New → Invalid
Changed in hwe-next:
status: New → Fix Released
Changed in linux-oem-5.17 (Ubuntu):
status: New → Invalid
Changed in linux (Ubuntu Kinetic):
status: New → Fix Released
Changed in linux-oem-5.14 (Ubuntu Kinetic):
status: New → Invalid
Changed in linux-oem-5.17 (Ubuntu Kinetic):
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.