Ubuntu
ruby-mysql2 package

autopkgtest fails for mysql-8.0 version 8.0.29

Bug #1981343 reported by Lena Voytek
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ruby-mysql2 (Ubuntu)
Fix Released
Undecided
Lena Voytek
Jammy
Fix Committed
Undecided
Lena Voytek
Kinetic
Fix Released
Undecided
Lena Voytek

Bug Description

[Impact]

When sending fixes/updates to mysql-8.0 and ruby-mysql2 in jammy, an autopkgtest will fail with:
TypeError: no implicit conversion of Time into String

mysql 8.0.28 had a regression in its datetime and time query handling, and as such a patch was created for this autopkgtest to change its behavior. However, in 8.0.29 the functionality was restored, making the patch break the test.

Removing the autopkgtest patch to go back to the original setup fixes the test, allowing features and bug fixes to go through again.

[Test Plan]

The current update for mysql shows the autopkgtest regression here: https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/amd64/r/ruby-mysql2/20220702_030243_5e5aa@/log.gz
To show that the removal of the patch fixes this, run autopkgtests with ppa:lvoytek/ruby-mysql2-revert-datetime-test-change-jammy

[Where problems could occur]

With this patch removed, any future changes to mysql's handling of datetimes and times in ? queries could cause this test to fail again, blocking features and bug fixes for mysql and ruby-mysql2. This fix will revert ruby-mysql2 to how it was in 0.5.3-3ubuntu3, but this was mainly tested alongside mysql 8.0.27. Therefore changes between that version and 8.0.29 may not be fully accounted for in the datetime and time test.

[Other Info]

Patch was removed in kinetic in ruby-mysql2 version 0.5.3-3ubuntu5.

[Original Description]

Due to an accidental change with the ? query for Time and Datetime in Mysql 8.0.28, a patch was added to ruby-mysql2 to keep the autopkgtests working. The change was reverted in 8.0.29 causing the tests to fail again. Removing the ruby-mysql2 test patch fixes this issue.

See original description

Related branches

~lvoytek/ubuntu/+source/ruby-mysql2:restore-datetime-query-test-jammy
git-ubuntu bot: Approve
Lucas Kanashiro (community): Approve
Canonical Server Reporter: Pending requested
Diff: 68 lines (+8/-38)
3 files modified
debian/changelog (+8/-0)
debian/patches/series (+0/-1)
dev/null (+0/-37)
Lena Voytek (lvoytek)
Changed in ruby-mysql2 (Ubuntu Kinetic):
status: New → Fix Released
assignee: nobody → Lena Voytek (lvoytek)
Changed in ruby-mysql2 (Ubuntu Jammy):
assignee: nobody → Lena Voytek (lvoytek)
status: New → In Progress
Lena Voytek (lvoytek)
description: updated
Revision history for this message
Steve Langasek (vorlon) wrote :

This SRU gives as its justification the fix of an automated test, but from viewing the debdiff for this package I cannot tell that the affected code is test code as opposed to functional code in the module.

If this is only test code, the bug should be tagged block-proposed-jammy, so that we do not release an SRU for this fix alone to the -updates pocket, only the -proposed pocket.

If it is functional code, that should be expressed clearly in the bug description.

Changed in ruby-mysql2 (Ubuntu Jammy):
status: In Progress → Incomplete
Revision history for this message
Robie Basak (racb) wrote :

It's all test code. spec/ refers to rspec, a language for writing tests in Ruby. I'll tag block-proposed-jammy, though I think this would mean that we'll have to manually retry autopkgtest against ruby-mysql2 in jammy-proposed when a new MySQL comes through. We can look again at that later if needed.

tags: added: block-proposed-jammy
Changed in ruby-mysql2 (Ubuntu Jammy):
status: Incomplete → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Lena, or anyone else affected,

Accepted ruby-mysql2 into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ruby-mysql2/0.5.3-3ubuntu4.22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Lena Voytek (lvoytek) wrote :

Ran autopkgtests locally with proposed enabled and confirmed that all succeeded, sorry for the delay

tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.