hg-git: bionic autopkgtests fails due to extraneous git output and unexpected return code

Ah, thanks for catching that missing tag @ahasenack!

Hi Dann, thanks for this fix!

Just a question: why did you think it would be important to make the test pass with old versions of git, which still have the original output, and exit status 0? Shouldn't we update the test to work with the version of git we have in bionic-security/updates at the moment, and fail otherwise? I'm a bit uncomfortable with the || true you added to the git clone command in that particular test.

Hi Andreas. Thank you for your careful review.

I chose to pull the entire patch from upstream instead of crafting a targeted fix myself. That would have been more clear had I included DEP-3 headers in the patch - and I think I should reupload w/ that added, even if nothing else. Here's a link in the meantime:
  https://foss.heptapod.net/mercurial/hg-git/-/commit/bcd2dba8053e658e06930e6a9e6f9b19764953a7

Since that changeset technically addresses 2 different issues (return code and extra output), I did consider dropping the return code piece. I'm happy to do that if you prefer (and it sounds like you do). Arguments for keeping it would be that it is more portable, and no less permissive than what we have in later releases. But of course, we're not experiencing the return code issue, so addressing it here is in conflict with the idea of a surgical fix.

I would prefer to retain the optional error message support though - I don't see a good reason for being more restrictive than upstream there, and doing so should help avoid conflicts if we need to backport additional changes in this area.

So to summarize, I suggest I reupload by adding DEP-3 headers to the patch and dropping the return code portion of the patch. What do you think?

Yes, please update the bionic patch with the dep3 header indicating its origin, and other info as needed.

Done. Turns out the return code had changed as well, so I kept the entire upstream patch.

Hello dann, or anyone else affected,

Accepted hg-git into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/hg-git/0.8.11-1ubuntu0.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

The fix for this bug has been awaiting testing feedback in the -proposed repository for bionic for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

= Verification =
bionic's tests now pass:
https://autopkgtest.ubuntu.com/packages/hg-git

The version of hg-git in the proposed pocket of Bionic that was purported to fix this bug report has been removed because the bugs that were to be fixed by the upload were not verified in a timely (105 days) fashion.

Resurrected the removed upload into bionic-proposed. After some discussion we decided not to remove autopkgtest regression fix uploads from -proposed for series that are transitioning to ESM as they might be useful as a base for any ESM follow up uploads.