Evergreen

Add author and non-override name to carousel APIs

Bug #2009891 reported by Jeff Davis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned
Evergreen 3.12-beta

Bug Description

EG 3.9+

The open-ils.actor.carousel.retrieve_by_org API returns a carousel's override name, but not the default name, which means you have to do another API call to get the carousel name if it has no override name. It would be convenient if the default name was included in the initial response.

It would also be handy if the open-ils.actor.carousel.get_contents API included the item author as well as title.

Terran McCanna (tmccanna)
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Wishlist
tags: added: opac-carousel
Jeff Davis (jdavis-sitka)
Changed in evergreen:
assignee: nobody → Jeff Davis (jdavis-sitka)
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Top two commits in working branch user/jeffdavis/lp2009891-carousel-api-additions implement these changes:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp2009891-carousel-api-additions

Changed in evergreen:
milestone: none → 3.11-beta
tags: added: pullrequest
Changed in evergreen:
assignee: Jeff Davis (jdavis-sitka) → nobody
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Pushed a third commit with brief release notes.

Jeff Davis (jdavis-sitka)
tags: added: needswork
removed: pullrequest
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

The underlying SQL query for the get_contents API can run very slowly, causing the API to be quite sluggish (45-60s in some tests). In my environment, performance can be drastically improved (to ~5s) by changing the core table from biblio.record_entry to container.biblio_record_entry_bucket_item. I'll put together a revised patch to do that.

Changed in evergreen:
assignee: nobody → Jeff Davis (jdavis-sitka)
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp2009891-carousel-api-additions-2 has a revised fix (top 3 commits):

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp2009891-carousel-api-additions-2

In this branch, open-ils.actor.carousel.get_contents uses container.biblio_record_entry_bucket_item as the core table, and we also use reporter.materialized_simple_record instead of metabib.flat_display_entry to retrieve author and title information. This resolves the performance problem reported above.

Changed in evergreen:
assignee: Jeff Davis (jdavis-sitka) → nobody
tags: added: pullrequest
removed: needswork
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 3.11-beta → 3.12-beta
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Works great for me, Jeff. Thank you! Pushed for inclusion in 3.12.

Changed in evergreen:
status: Confirmed → Fix Committed
tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Apologies, all (especially Jeff)! I accidently committed the branch mentioned in comment #1, rather than the corrected patch mentioned in comment #4. This caused a failure in the perl live tests, which alerted me to the issue. I reverted the old version on main, and pushed the correct version instead.

Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.