Launchpad itself

Support underscores in release file names

Bug #202499 reported by Dennis Schridde
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Unassigned
Launchpad itself 2.2.7

Bug Description

Launchpad does not import beta or rc releases from URL pattern

For example https://launchpad.net/warzone2100/2.1 does not show any releases, even though the URL behind "Release URL pattern", http://download.gna.org/warzone/releases/2.1/, contains a 2.1_beta1 release.
The same goes for release candidates, eg. in http://download.gna.org/warzone/releases/2.0/ (which is the URL pattern for https://launchpad.net/warzone2100/2.0).

ADDENDUM:
The crux of the issue is that sane_version() recognises [.-] as delimiters. It could support [._-].

See original description
Revision history for this message
Philippe Coval (rzr) wrote :

It looks like you're missing the file patten also
can you try what happend if you set to URL pattern :

 http://download.gna.org/warzone/releases/2.0/warzone2100-*.tar.bz2

That's what I'll have to do for (I'll tell you if it worked for me) :

  https://launchpad.net/xnetcardconfig

Revision history for this message
Dennis Schridde (devurandom) wrote :

I currently have set http://download.gna.org/warzone/releases/2.0/*.tar.bz2
and http://download.gna.org/warzone/releases/2.1/*.tar.bz2

Apparently this detects x.y.z versions, but not x.y.z_abc123 ones. Maybe because that scheme is not used by Ubuntu? Afaik they use x.y.z-abc123 instead...

I also think that the location of the original downloads should be displayed (optional maybe). Though that probably is a different "bug".

Revision history for this message
Philippe Coval (rzr) wrote :

Strange...

BTW in x.y.z-abc123 , -abc123 is for patch revision

watch for uscan if it is based on the same rules

Regards

Revision history for this message
Curtis Hovey (sinzui) wrote :

Launchpad does not recognise the "_" in the file name. It excepts numbers and letters separated by dots and dashes ".-" So the pattern x.y.z_abc123 is not accepted, but x.y.z-abc123 is. Beta and RC are accepted, for example 1.3.beta or 1.2.3-rc3.

Changed in launchpad-registry:
importance: Undecided → Low
status: New → Invalid
Revision history for this message
Dennis Schridde (devurandom) wrote :

In that case you may want to allow an additional version name scheme. Trying to force everyone to the one you decided to use does not sound like an option.

Changed in launchpad-registry:
status: Invalid → New
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: New → Triaged
description: updated
Revision history for this message
Curtis Hovey (sinzui) wrote :

I think support for the underscore can be added when we update the productreleasefinder process in the near future.

Changed in launchpad-registry:
importance: Low → Wishlist
Curtis Hovey (sinzui)
Changed in launchpad-registry:
assignee: nobody → Curtis Hovey (sinzui)
milestone: none → 2.2.7
status: Triaged → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fixed in launchpad devel r8700.

Changed in launchpad-registry:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
tags: added: story-product-release-finder
Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 202499 Fix released

Fixed released in Launchpad 2.2.7.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.