[MIR] gnome-clocks
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| gnome-clocks (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
[Availability]
The package gnome-clocks is already in Ubuntu universe.
The package gnome-clocks build for the architectures it is designed to work on.
It currently builds and works for architectures: amd64 arm64 armhf ppc64el riscv64 s390x
Link to package https:/
[Rationale]
- The package gnome-clocks is required in Ubuntu main as a desktop application and to allow integration of extra timezones to the shell calendar interface
- There is no other/better way to solve this that is already in main or
should go universe->main instead of this.
- It would be great and useful to community/processes to have the
package gnome-clocks in Ubuntu main, but there is no definitive deadline.
[Security]
- No CVEs/security issues in this software in the past
- no `suid` or `sgid` binaries
- no executables in `/sbin` and `/usr/sbin`
- Package does not install services, timers or recurring jobs
- Packages does not open privileged ports (ports < 1024).
- Package does not expose any external endpoints
- Packages does not contain extensions to security-sensitive software
[Quality assurance - function/usage]
- The package works well right after install
[Quality assurance - maintenance]
- The package is maintained well in Debian/
- Ubuntu https:/
- Debian https:/
- Upstream's bug tracker, https:/
- The package does not deal with exotic hardware we cannot support
[Quality assurance - testing]
- The package runs limited tests at build time, it's a desktop application and integration in the desktop which isn't easy to test and upstream isn't providing those.
Build log https:/
We wrote an additional manual testplan on https:/
- The package does not run an autopkgtest because it's a graphical GTK application and we currently don't really have a way to do test those currently in the autopkgest infrastructure.
[Quality assurance - packaging]
- debian/watch is present and works
- debian/control defines a correct Maintainer
- The package only has minor lintian warnings
# lintian --pedantic gnome-clocks_
W: gnome-clocks: no-manual-page [usr/bin/
W: gnome-clocks source: no-nmu-in-changelog [debian/
W: gnome-clocks source: source-
- Lintian overrides are not present
- This package does not rely on obsolete or about to be demoted packages.
- This package has no python2 or GTK2 dependencies
- The package will be installed by default, but does not ask debconf questions
- Packaging and build is easy, link to debian/rules https:/
[UI standards]
- Application is end-user facing, Translation is present, via standard gettext
- End-user applications that ships a standard conformant desktop file
[Dependencies]
- No further depends or recommends dependencies that are not yet in main
[Standards compliance]
- This package correctly follows FHS and Debian Policy
[Maintenance/Owner]
- Owning Team will be desktop-packages
- Team is already subscribed to the package
- This does not use static builds
- This does not use vendored code
- This package is not rust based
- The package has been built in the archive more recently than the last
test rebuild
[Background information]
The Package description explains the package well
Upstream Name is gnome-clocks
Link to upstream project https:/
| Changed in gnome-clocks (Ubuntu): | |
| assignee: | nobody → Christian Ehrhardt (paelzer) |
| description: | updated |
| Christian Ehrhardt (paelzer) wrote | #1 |
| Changed in gnome-clocks (Ubuntu): | |
| status: | New → In Progress |
| assignee: | Christian Ehrhardt (paelzer) → nobody |
| Sebastien Bacher (seb128) wrote | #2 |
| description: | updated |
| Changed in gnome-clocks (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Sebastien Bacher (seb128) wrote | #3 |
| Changed in gnome-clocks (Ubuntu): | |
| status: | Fix Committed → Fix Released |
Review for Source Package: gnome-clocks
[Summary]
MIR team ACK
This does not need a security review
List of specific binary packages to be promoted to main: gnome-clocks
Specific binary packages built, but NOT to be promoted to main: none
Recommended TODOs:
- #1 an autopkgtest would be nice, but TBH I'm unsure if that is doable
without over-investing, so really please consider this nice to have.
- #2 The package should get a team bug subscriber before being promoted
[Duplication]
There is no other package in main providing the same functionality.
Furthermore I know from community interactions (and using it myself) that this
can be quite useful to track time across timezones - so it would be great to
have it in main for more than just the requested dependency :-)
[Dependencies]
OK:
- no other Dependencies to MIR due to this
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems: None
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
Problems: None
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
xml, json, asn.1], network packets, structures, ...) from
an untrusted source.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)
Problems: None
[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error (normal dh_auto_test).
- This does not need special HW for build or test
- no new python2 dependency
Problems:
- does not have a non-trivial test suite that runs as autopkgtest. But then I
might not be creative enough - the use cases are hard to test in automation
and the scope is narrow so chances are high that any user of it would find
an issue if there is one (that is different with stacks that have 1001
different use cases). Hence I consider an autopkgtest for this package
nice to have, but not strictly required.
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok
- Upstream update history is good
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package (all are team members of the now owning team)
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled...