[needs-packaging] u-boot-s32

Bug #2034650 reported by Laider Lai
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
u-boot-s32 (Ubuntu)
Fix Released
Wishlist
NemOS Team

Bug Description

[needs-packaging] u-boot-s32 (2022.04-bsp37.0-0ubuntu1)
For Erlangen project, we have to provide the NXP S32G U-boot to the customer via Ubuntu archive (universe).

URL: https://launchpad.net/~nemos-team/+archive/ubuntu/archive-target/+packages
Source code: https://code.launchpad.net/~nemos-team/nemos/+git/u-boot-s32/+ref/ubuntu/archive
License: https://git.launchpad.net/~nemos-team/nemos/+git/u-boot-s32/tree/debian/copyright
Notes: The NXP S32G U-boot [Noble]

Laider Lai (laiderlai)
information type: Public → Private
Changed in ubuntu:
assignee: nobody → Laider Lai (laiderlai)
status: New → In Progress
Laider Lai (laiderlai)
information type: Private → Public
Revision history for this message
Brian Murray (brian-murray) wrote :

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

Changed in ubuntu:
importance: Undecided → Wishlist
Revision history for this message
Dave Jones (waveform) wrote :

The d/watch file in the packaging looks correct (points to the https://github.com/nxp-auto-linux/u-boot repo), but the corresponding lines in d/control are almost certainly wrong (source.codeaurora.org appears to have shut down).

The diff to the base v2022.04 of u-boot looks quite large (26K lines or so) so a separate package is almost certainly preferable to trying to fold this into our existing u-boot package. However, I'm a bit concerned as to whether this stands a chance of being upstreamed (i.e. whether this package will be required indefinitely or whether it can eventually be retired in favour of the general u-boot package).

In addition, many of the files added appear to have no corresponding entries in d/copyright (or where they match existing patterns the copyrights haven't been updated to cover NXP, who appear to be the originator of most changes).

Revision history for this message
Dave Jones (waveform) wrote :

Unsubscribing ubuntu-sponsors for now; please re-subscribe ubuntu-sponsors when the requested changes are ready for review. Thanks!

Revision history for this message
Isaac True (itrue) wrote :

Thanks for the feedback, I'll work on the copyright file. I've already updated the URLs in d/control in the source repo.

> However, I'm a bit concerned as to whether this stands a chance of being upstreamed (i.e. whether this package will be required indefinitely or whether it can eventually be retired in favour of the general u-boot package).

The NXP S32 changes will unfortunately likely never be upstreamed, as there are a number of drivers and features that need proprietary firmware to work, and like you said the diff is pretty huge. Maybe at some point NXP will upstream a bare minimum patchset to get it to work, but at this stage it's unlikely. U-Boot is also responsible for setting up the SERDES lane muxing for Ethernet and PCIe (I'm really not sure why they did it this way and not in Linux...) so there is a lot of complexity and logic that's been added.

Revision history for this message
Isaac True (itrue) wrote :

I've updated the copyright information in the repository.

Laider Lai (laiderlai)
Changed in ubuntu:
assignee: Laider Lai (laiderlai) → NemOS Team (nemos-team)
Revision history for this message
Laider Lai (laiderlai) wrote :

Please hold on for this request.
Because the same platform's kernel resources may have some limitations.

We have to confirm the find public method about the kernel resources. Tks.

Changed in ubuntu:
status: In Progress → Incomplete
Revision history for this message
Jeremy Bícha (jbicha) wrote :

I am unsubscribing ubuntu-sponsors based on your last comment asking for no action to be taken at this time.

Please subscribe ubuntu-sponsors when you are ready for sponsor help.

Revision history for this message
Laider Lai (laiderlai) wrote :

After checking with the HWE team, the kernel resources are okay to be published to the Ubuntu archive.
Therefore, the release target (Ubuntu archive) review process can continue.

Changed in ubuntu:
status: Incomplete → In Progress
Laider Lai (laiderlai)
description: updated
Laider Lai (laiderlai)
description: updated
Laider Lai (laiderlai)
description: updated
Revision history for this message
Dave Jones (waveform) wrote :

I've now done a full build on the current version of the package. There's quite a lot of lintian warnings in the result, but the vast majority are also found (or ignored by) the general u-boot package, so are not terribly relevant here.

Unfortunately, I'm now getting an FTBFS on the main u-boot package under noble, which I was attempting to compare lintian tags between this and a fresh build of u-boot. Anyway, I'll continue looking into this tomorrow, but assuming I can clear up my concerns over the remaining lintian tags, I'll be happy to sponsor this.

Revision history for this message
Laider Lai (laiderlai) wrote :

Thanks for the review. If necessary, happy for any help.

*Since the development series is moved to Noble. Update the description target to Noble.

description: updated
Laider Lai (laiderlai)
description: updated
Laider Lai (laiderlai)
description: updated
Revision history for this message
Laider Lai (laiderlai) wrote :

Got reject information:
incorrect version number for an Ubuntu-only upload. Incorrect assertion of 'GPL-3+' licensing which is inconsistent with Canonical copyright policy. SPDX-License-Identifier garbage header in debian/copyright.

There is the latest version (u-boot-s32 - 2022.04-bsp37.0-0ubuntu18) fixed problems.
 - The version format is refined.
 - The copyright remove garbage header
 - The copyright fix license problem
 - Confirmed lintian test result is passed

Hi Dave Jones,

Could you help to re-upload the latest version to the noble upload queue? Tks.

description: updated
Revision history for this message
Dave Jones (waveform) wrote :

Thanks Laider -- I've uploaded the current version in the PPA, with the version adjusted to 2022.04-bsp37.0-0ubuntu1, and this bug added to the changelog message.

Revision history for this message
Laider Lai (laiderlai) wrote :

Thanks Dave, just a description update to let you know I refine the package version (u-boot-s32 - 2022.04-bsp37.0-0ubuntu1) of PPA with your development suggestion. No content changing.

description: updated
Laider Lai (laiderlai)
description: updated
Jeremy Bícha (jbicha)
affects: ubuntu → u-boot-s32 (Ubuntu)
Changed in u-boot-s32 (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.