[needs-packaging] optee-test-s32

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

Uploaded, thank you!

*Since the development series is moved to Noble. Update the description target to Noble.

Hi Simon (tsimonq2),
Thanks for your sponsor, could you help to share where the package is uploaded from comment#2?

Tks.

Got reject information:
incorrect version number for an Ubuntu-only upload. Incorrect assertion of 'GPL-3+' licensing which is inconsistent with Canonical copyright policy. SPDX-License-Identifier garbage header in debian/copyright. debian/copyright fails lintian checks. debian/copyright does not match upstream license information (bundled OpenSSL)

There is the latest version (optee-test-s32 - 3.18.0-0ubuntu3) fixed problems.
 - The version format is refined.
 - The copyright remove garbage header
 - The copyright fix license problem
 - The bundled OpenSSL is removed
 - Confirmed lintian test result is passed

Hi Dave Jones,

Could you help to re-upload the latest version to the noble upload queue? Tks.

Where is this source tarball downloaded from? There is no debian/watch file, could you please add one?

Would it be https://github.com/OP-TEE/optee_test/archive/refs/tags/3.18.0.tar.gz perhaps?

Also, where are the build-dependencies? It looks like nemos-dev-cert and nemos-dev-key are not in the archive, just in your ppa? Is there another needs-packaging bug for those?

Hi Laider, I've had a look at the package and Andreas' concerns (and a few of mine) do need addressing first. Specifically:

* There's no need for copyright comments in d/control, d/copyright, or d/rules -- the "Files: debian/*" clause in d/copyright defines that Canonical has the copyright of all files in debian/

* Given the declared upstream repo (https://github.com/OP-TEE/optee_test) has release tags, it would certainly be to our advantage to have a d/watch file included. I'd suggest something like the following (allowing for the fact Launchpad is going to butcher the wrapping here):

  version=4

  opts=\
    filenamemangle=s/.+\/@ANY_VERSION@\.tar\.gz/@PACKAGE@_$1.orig.tar.gz/ \
    https://github.com/OP-TEE/optee_test/tags .*\/@ANY_VERSION@\.tar\.gz \
    debian

* Technically, the version number ought to be ...-0ubuntu1 but I'm happy to adjust that sort of thing during sponsorship. A hint for working with PPAs: I generally find it's easiest to upload with the "correct" version number plus a ~ppa1 suffix which I can then bump with subsequent revisions; the "~" ensures it sorts before the final revision, so anything using the PPA will eventually upgrade implicitly to the archive revision. For example in this case I would've uploaded something like 3.18.0-0ubuntu1~ppa1 then revised to 3.18.0-0ubuntu1~ppa2 and so on. Eventually, 3.18.0-0ubuntu1 would be uploaded to the archive and that sorts after the PPA revisions

* Andreas is correct in noting that nemos-dev-key and nemos-dev-cert are needed first. For reference, LP: #2043448 is the needs-packaging bug for nemos-dev-key (which also produces nemos-dev-cert). That's been sponsored by @tsimonq2 already, but hasn't been accepted into the archive yet. I suspect it's worth waiting to see what the AAs say about nemos-dev-key before uploading this

Thanks Andreas and Dave.
1. The d/watch is added and unnecessary copyrights from debian/* are removed.
2. The version is refined as 3.18.0-0ubuntu1 in PPA.

Indeed about the dependency and mark it in the description.
When nemos-dev-key is uploaded to the archive, then I will subscribe sponsor team again for this case. Tks.