subiquity

Crash when /storage/v2/orig_config is called too early

Bug #2039080 reported by Olivier Gayot on 2023-10-11

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	subiquity	Fix Released	Undecided	Olivier Gayot

Bug Description

Sometimes, with the desktop installer, the /storage/v2/orig_config endpoint is called to early. It results in the following errors:

2023-09-22 11:21:32,641 DEBUG root:30 finish: subiquity/Filesystem/v2_orig_config_GET: SUCCESS: 500 Traceback (most recent call last):
  File "/snap/ubuntu-desktop-installer/124...
2023-09-22 11:21:32,641 DEBUG subiquity.server.server:448 request to /storage/v2/orig_config crashed
Traceback (most recent call last):
  File "/snap/ubuntu-desktop-installer/1243/bin/subiquity/subiquity/common/api/server.py", line 164, in handler
    result = await implementation(**args)
  File "/snap/ubuntu-desktop-installer/1243/bin/subiquity/subiquity/server/controllers/filesystem.py", line 1029, in v2_orig_config_GET
    model = self.model.get_orig_model()
  File "/snap/ubuntu-desktop-installer/1243/bin/subiquity/subiquity/models/filesystem.py", line 1428, in get_orig_model
    orig_model.load_probe_data(self._probe_data)
  File "/snap/ubuntu-desktop-installer/1243/bin/subiquity/subiquity/models/filesystem.py", line 1894, in load_probe_data
    for devname, devdata in probe_data["blockdev"].items():
TypeError: 'NoneType' object is not subscriptable
2023-09-22 11:21:32,641 DEBUG subiquity.common.errorreport:394 generating crash report
2023-09-22 11:21:32,642 INFO subiquity.common.errorreport:415 saving crash report 'request to /storage/v2/orig_config crashed with TypeError' to /var/crash/1695381692.641920805.server_request_fail.crash
2023-09-22 11:21:32,642 INFO aiohttp.access:206 [22/Sep/2023:11:21:32 +0000] "GET /storage/v2/orig_config HTTP/1.1" 500 1205 "-" "Dart/3.0 (dart:io)"
2023-09-22 11:21:32,643 INFO root:30 start: subiquity/ErrorReporter/1695381692.641920805.server_request_fail/add_info:
2023-09-22 11:21:32,645 DEBUG root:30 start: subiquity/Filesystem/v2_orig_config_GET:
2023-09-22 11:21:32,646 DEBUG root:30 finish: subiquity/Filesystem/v2_orig_config_GET: SUCCESS: 500 Traceback (most recent call last):
  File "/snap/ubuntu-desktop-installer/124...
2023-09-22 11:21:32,646 DEBUG subiquity.server.server:448 request to /storage/v2/orig_config crashed
Traceback (most recent call last):
  File "/snap/ubuntu-desktop-installer/1243/bin/subiquity/subiquity/common/api/server.py", line 164, in handler
    result = await implementation(**args)
  File "/snap/ubuntu-desktop-installer/1243/bin/subiquity/subiquity/server/controllers/filesystem.py", line 1029, in v2_orig_config_GET
    model = self.model.get_orig_model()
  File "/snap/ubuntu-desktop-installer/1243/bin/subiquity/subiquity/models/filesystem.py", line 1428, in get_orig_model
    orig_model.load_probe_data(self._probe_data)
  File "/snap/ubuntu-desktop-installer/1243/bin/subiquity/subiquity/models/filesystem.py", line 1894, in load_probe_data
    for devname, devdata in probe_data["blockdev"].items():
TypeError: 'NoneType' object is not subscriptable