Concurrent updates of separate threads in a shared repository fails

Bug #204025 reported by Russel Winder
2
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
High
Unassigned

Bug Description

I have a repository with two branches. When I started an update in each branch concurrently, the one started first worked fine, the one started second gave an error (below) with its request to file a bug report. When rerun the update completed successfully so my hypothesis is that this is not really a troublesome bug, just a situation in need of a less drastic and dramatic response.

|> bzr update
Unable to obtain lock file:///home/users/russel/Repositories/Bazaar/Checkouts/Gant/.bzr/repository/lock
held by <email address hidden> on host balin [process #25636]
locked 7 seconds ago
Will continue to try until 10:40:14

bzr: ERROR: exceptions.AttributeError: 'NoneType' object has no attribute 'abort'

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 806, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 762, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 492, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/builtins.py", line 1070, in run
    tree.unlock()
  File "/usr/lib/python2.5/site-packages/bzrlib/workingtree_4.py", line 1134, in unlock
    self.branch.unlock()
  File "/usr/lib/python2.5/site-packages/bzrlib/branch.py", line 1366, in unlock
    self.repository.unlock()
  File "/usr/lib/python2.5/site-packages/bzrlib/repofmt/pack_repo.py", line 2005, in unlock
    self.abort_write_group()
  File "/usr/lib/python2.5/site-packages/bzrlib/repository.py", line 482, in abort_write_group
    self._abort_write_group()
  File "/usr/lib/python2.5/site-packages/bzrlib/repofmt/pack_repo.py", line 1847, in _abort_write_group
    self._pack_collection._abort_write_group()
  File "/usr/lib/python2.5/site-packages/bzrlib/repofmt/pack_repo.py", line 1651, in _abort_write_group
    self._new_pack.abort()
AttributeError: 'NoneType' object has no attribute 'abort'

bzr 1.1.0 on python 2.5.1.final.0 (linux2)
arguments: ['/usr/bin/bzr', 'update']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_GB.UTF-8'
plugins:
  builddeb /usr/lib/python2.5/site-packages/bzrlib/plugins/builddeb [unknown]
  bzrtools /usr/lib/python2.5/site-packages/bzrlib/plugins/bzrtools [1.1.0]
  gtk /usr/lib/python2.5/site-packages/bzrlib/plugins/gtk [0.93.0]
  launchpad /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
  multiparent /usr/lib/python2.5/site-packages/bzrlib/plugins/multiparent.pyc [unknown]
  svn /usr/lib/python2.5/site-packages/bzrlib/plugins/svn [0.4.7]
  xmloutput /home/users/russel/.bazaar/plugins/xmloutput [0.4.1]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 204025] [NEW] Concurrent updates of separate threads in a shared repository fails

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Russel Winder wrote:
| Public bug reported:
|
| I have a repository with two branches. When I started an update in each
| branch concurrently, the one started first worked fine, the one started
| second gave an error (below) with its request to file a bug report.
| When rerun the update completed successfully so my hypothesis is that
| this is not really a troublesome bug, just a situation in need of a less
| drastic and dramatic response.
|
|

~ status Fix Released
~ milestone 1.2

This was fixed in 1.2. It basically just means that there weren't any changes to
push, and the unlock thought there were.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH4YnUJdeBCYSNAAMRAmUzAKCv5CS+c78z7JXYFyhPFg1DiYksagCeL3DQ
qJsbOMAt9FiqKlmGJEXzIvU=
=10LA
-----END PGP SIGNATURE-----

John A Meinel (jameinel)
Changed in bzr:
importance: Undecided → High
milestone: none → 1.2
status: New → Fix Released
Revision history for this message
Russel Winder (russel) wrote : Re: [Bug 204025] [NEW] Concurrent updates of separate threads in a shared repository fails

John,

On Wed, 2008-03-19 at 21:47 +0000, John A Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Russel Winder wrote:
> | Public bug reported:
> |
> | I have a repository with two branches. When I started an update in each
> | branch concurrently, the one started first worked fine, the one started
> | second gave an error (below) with its request to file a bug report.
> | When rerun the update completed successfully so my hypothesis is that
> | this is not really a troublesome bug, just a situation in need of a less
> | drastic and dramatic response.
> |
> |
>
> ~ status Fix Released
> ~ milestone 1.2
>
>
> This was fixed in 1.2. It basically just means that there weren't any changes to
> push, and the unlock thought there were.

Excellent :-)

<gentle-dig>
I guess I would not have seen this if all the bits of Bazaar I use, bzr,
bzrtools, bzr-svn, bzr-gtk, had all had a consistent 1.2-connected
Gutsy release on https://launchpad.net/~bzr/+archive aka
http://ppa.launchpad.net/bzr/ubuntu
</gentle-dig>

I'm looking forward to using 1.3 :-)

PS My immediate need is to have a really good and as fast as possible
Bazaar install for the version control session that Jim Hague and myself
are putting on at the accu2008 conference in two weeks time. This is a
"Why DVCS is better than CVCS" aka "Why Bazaar/Mercurial/Git are better
than Subversion/Perforce/ClearCase" session -- its a follow on from Tim
Penhey's BOF at accu2007. Tim was originally going to be a copresenter
but couldn't travel to get to this year's conference, so it is just me
and Jim.

--
Russel.
====================================================
Dr Russel Winder Partner

Concertant LLP t: +44 20 7193 9203
41 Buckmaster Road, f: +44 8700 516 084
London SW11 1EN, UK. m: +44 7770 465 077

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.