Demote glusterfs for noble

Bug #2045063 reported by Andreas Hasenack
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Release Notes for Ubuntu
Fix Released
Undecided
Andreas Hasenack
glusterfs (Ubuntu)
Fix Released
High
Andreas Hasenack
qemu (Ubuntu)
Fix Released
High
Andreas Hasenack
samba (Ubuntu)
Fix Released
High
Andreas Hasenack
ubuntu-release-upgrader (Ubuntu)
Opinion
High
Andreas Hasenack

Bug Description

GlusterFS should be demoted to Universe for the next ubuntu LTS: Noble

This implies changes to:
- samba
- qemu
- other reverse-deps I might have missed
- seeds

For samba, *maybe* we can create a new package to include the glusterfs vfs module(s), and put that in universe.

Tags: server-todo

Related branches

CVE References

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

FYI: I already gave you the go, but we now also have all other confirmations in that we wanted.

For qemu we could also consider to keep it enabled and move:
  /usr/lib/x86_64-linux-gnu/qemu/block-gluster.so
From qemu-block-extra to a universe subpackage.
Hard naming question since the common -extra is already taken.

qemu-block-extra-extra or qemu-block-further seem wrong :-)

In a lovely discussion with Bryce we came up with qemu-block-supplemental :-P

Changed in glusterfs (Ubuntu):
status: New → In Progress
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

There is a general release-upgrade problem to consider here.

Let's say you have samba installed on mantic, and are using glusterfs. The glusterfs module comes in the samba-vfs-modules package, which is in main.

In noble we then split that module out to bin:samba-vfs-modules-glusterfs, and place that in universe. There is no dependency between bin:samba-vfs-modules(main) and bin:samba-vfs-modules-glusterfs(universe).

If you release-upgrade from mantic to noble, you will get the new bin:samba-vfs-modules(main) which does not have the glusterfs module, and your samba installation will likely break.

You can still install it, and unbreak your system, but do-release-upgrade might have failed already (because postinst failed to restart samba, for example, given the module is not on disk anymore), or at least you will have a broken noble installation for a while.

And I don't see a way to pre-empt this problem. Even if you read the release notes, and become aware of this, there is nothing you can do *prior* to the release-upgrade to not be left with this broken upgrade.

Specifically for the samba case, I believe there will only be an error when the actual share which is using glusterfs is contacted, but this is still a general problem. For qemu, I don't know yet what the failure scenario is once we move the gluster module out of qemu-block-extra and release-upgrade. Keeping in mind that a reboot is needed after the release upgrade, I believe existing VMs using the glusterfs module would just fail to start.

Changed in qemu (Ubuntu):
assignee: nobody → Andreas Hasenack (ahasenack)
status: New → In Progress
Changed in samba (Ubuntu):
status: New → In Progress
assignee: nobody → Andreas Hasenack (ahasenack)
Changed in qemu (Ubuntu):
importance: Undecided → High
Changed in samba (Ubuntu):
importance: Undecided → High
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Very good tip[1] on ubuntu-devel@ from Nick Rosbrook about the release upgrade problem, thanks!

1. https://lists.ubuntu.com/archives/ubuntu-devel/2024-January/042873.html

Changed in qemu (Ubuntu):
milestone: none → ubuntu-24.01
Changed in samba (Ubuntu):
milestone: none → ubuntu-24.01
tags: added: server-todo
Changed in ubuntu-release-upgrader (Ubuntu):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Andreas Hasenack (ahasenack)
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

samba and qemu were uploaded to noble-proposed, and are going through migration. Marking their respective tasks as "fix committed".

Changed in qemu (Ubuntu):
status: In Progress → Fix Committed
Changed in samba (Ubuntu):
status: In Progress → Fix Committed
Changed in ubuntu-release-upgrader (Ubuntu):
status: In Progress → Triaged
Revision history for this message
Andy Whitcroft (apw) wrote :
Download full text (3.8 KiB)

Override component to universe
glusterfs 11.1-4 in noble: main/admin -> universe
glusterfs-cli 11.1-4 in noble amd64: main/admin/optional/100% -> universe
glusterfs-cli 11.1-4 in noble arm64: main/admin/optional/100% -> universe
glusterfs-cli 11.1-4 in noble ppc64el: main/admin/optional/100% -> universe
glusterfs-cli 11.1-4 in noble riscv64: main/admin/optional/100% -> universe
glusterfs-cli 11.1-4 in noble s390x: main/admin/optional/100% -> universe
glusterfs-client 11.1-4 in noble amd64: main/admin/optional/100% -> universe
glusterfs-client 11.1-4 in noble arm64: main/admin/optional/100% -> universe
glusterfs-client 11.1-4 in noble ppc64el: main/admin/optional/100% -> universe
glusterfs-client 11.1-4 in noble riscv64: main/admin/optional/100% -> universe
glusterfs-client 11.1-4 in noble s390x: main/admin/optional/100% -> universe
glusterfs-common 11.1-4 in noble amd64: main/libs/optional/100% -> universe
glusterfs-common 11.1-4 in noble arm64: main/libs/optional/100% -> universe
glusterfs-common 11.1-4 in noble ppc64el: main/libs/optional/100% -> universe
glusterfs-common 11.1-4 in noble riscv64: main/libs/optional/100% -> universe
glusterfs-common 11.1-4 in noble s390x: main/libs/optional/100% -> universe
glusterfs-server 11.1-4 in noble amd64: main/admin/optional/100% -> universe
glusterfs-server 11.1-4 in noble arm64: main/admin/optional/100% -> universe
glusterfs-server 11.1-4 in noble ppc64el: main/admin/optional/100% -> universe
glusterfs-server 11.1-4 in noble riscv64: main/admin/optional/100% -> universe
glusterfs-server 11.1-4 in noble s390x: main/admin/optional/100% -> universe
libgfapi0 11.1-4 in noble amd64: main/libs/optional/100% -> universe
libgfapi0 11.1-4 in noble arm64: main/libs/optional/100% -> universe
libgfapi0 11.1-4 in noble ppc64el: main/libs/optional/100% -> universe
libgfapi0 11.1-4 in noble riscv64: main/libs/optional/100% -> universe
libgfapi0 11.1-4 in noble s390x: main/libs/optional/100% -> universe
libgfchangelog0 11.1-4 in noble amd64: main/libs/optional/100% -> universe
libgfchangelog0 11.1-4 in noble arm64: main/libs/optional/100% -> universe
libgfchangelog0 11.1-4 in noble ppc64el: main/libs/optional/100% -> universe
libgfchangelog0 11.1-4 in noble riscv64: main/libs/optional/100% -> universe
libgfchangelog0 11.1-4 in noble s390x: main/libs/optional/100% -> universe
libgfrpc0 11.1-4 in noble amd64: main/libs/optional/100% -> universe
libgfrpc0 11.1-4 in noble arm64: main/libs/optional/100% -> universe
libgfrpc0 11.1-4 in noble ppc64el: main/libs/optional/100% -> universe
libgfrpc0 11.1-4 in noble riscv64: main/libs/optional/100% -> universe
libgfrpc0 11.1-4 in noble s390x: main/libs/optional/100% -> universe
libgfxdr0 11.1-4 in noble amd64: main/libs/optional/100% -> universe
libgfxdr0 11.1-4 in noble arm64: main/libs/optional/100% -> universe
libgfxdr0 11.1-4 in noble ppc64el: main/libs/optional/100% -> universe
libgfxdr0 11.1-4 in noble riscv64: main/libs/optional/100% -> universe
libgfxdr0 11.1-4 in noble s390x: main/libs/optional/100% -> universe
libglusterfs-dev 11.1-4 in noble amd64: main/libdevel/optional/100% -> universe
libglusterfs-dev 11.1-4 in noble arm64: main/libdevel/optional/100% -> univer...

Read more...

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package samba - 2:4.19.4+dfsg-3ubuntu1

---------------
samba (2:4.19.4+dfsg-3ubuntu1) noble; urgency=medium

  * Merge with Debian unstable (LP: #2051717). Remaining changes:
    - debian/control: Ubuntu i386 binary compatibility:
      + enable the liburing vfs module, except on i386 where liburing is
        not available
    - d/t/control, d/t/util,d/t/samba-ad-dc-provisioning-internal-dns:
      samba AD DC provisioning and domain join tests with internal DNS
      (LP #1977746, LP #2011745)
    - d/control: adjust breaks/replaces for file move that Debian did in
      4.16.6+dfsg-5, and Ubuntu only did in 4.17.7+dfsg-1ubuntu1, to avoid
      file conflict in a dist-upgrade from earlier Ubuntu releases, like
      Kinetic (LP #2024663)
    - d/control: python3-samba has a runtime dep on python3-markdown
    - glusterfs is no longer in main, create new binary package in
      universe to ship the samba glusterfs vfs modules and manpages
      (LP #2045063):
      + d/control: new samba-vfs-modules-glusterfs package
      + d/rules: glusterfs vfs modules and manpages are now in the
        samba-vfs-modules-extra package
      + d/samba-vfs-modules-extra.install: add glusterfs vfs modules and
        manpage
  * Added:
    - d/t/util: handle breakage introduced by lxd-installer. If on
      Ubuntu, assume lxd comes from a snap and install it if needed
    - d/t/util: ignore cloud-init's warning exit status, which is
      happening because of LP #2048129 (also see LP #2048522)

 -- Andreas Hasenack <email address hidden> Sat, 03 Feb 2024 10:14:42 -0300

Changed in samba (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.7 KiB)

This bug was fixed in the package qemu - 1:8.2.1+ds-1ubuntu1

---------------
qemu (1:8.2.1+ds-1ubuntu1) noble; urgency=medium

  * Merge with Debian unstable (LP: #2051883, #2049703). Remaining changes:
    - qemu-kvm to systemd unit
      - d/qemu-kvm-init: script for QEMU KVM preparation modules, ksm,
        hugepages and architecture specifics
      - d/qemu-system-common.qemu-kvm.service: systemd unit to call
        qemu-kvm-init
      - d/qemu-system-common.install: install helper script
      - d/qemu-system-common.qemu-kvm.default: defaults for
        /etc/default/qemu-kvm
      - d/rules: call dh_installinit and dh_installsystemd for qemu-kvm
    - Distribution specific machine type
      (LP 1304107 1621042 1776189 1761372 1761372 1776189)
      - d/p/ubuntu/define-ubuntu-machine-types.patch: define distro machine
        types containing release versioned machine attributes
      - Add an info about -hpb machine type in debian/qemu-system-x86.NEWS
      - ubuntu-q35 alias added to auto-select the most recent q35 ubuntu type
    - Enable nesting by default
      - d/p/ubuntu/enable-svm-by-default.patch: Enable nested svm by default
        in qemu64 on amd
        [ No more strictly needed, but required for backward compatibility ]
    - tolerate ipxe size change on migrations to >=18.04 (LP 1713490)
      - d/p/ubuntu/pre-bionic-256k-ipxe-efi-roms.patch: old machine types
        reference 256k path
      - d/control-in: depend on ipxe-qemu-256k-compat-efi-roms to be able to
        handle incoming migrations from former releases.
    - Ease the use of module retention on upgrades (LP 1913421)
      - debian/qemu-block-extra.postinst: enable mount unit on install/upgrade
    - Remaining GCC-12 FTBFS (LP 1988710 + LP 1921664)
      + d/p/u/qboot-Disable-LTO-for-ELF-binary-build-step.patch:
        fix qboot FTBFS with LTO
    - d/rules: Enable/disable extra features on microvm
      variant. (LP #2045594)
    - Move glusterfs storage driver to Universe in a new package
      (LP #2045063):
      + d/control{,-in}: new package qemu-block-supplemental for drivers
        we want in Universe
      + d/rules: we only want block-gluster.so in the new
        qemu-block-supplemental package. Adjust dynamically-created
        maintainer scripts for qemu-block-extra and -supplemental.

qemu (1:8.2.1+ds-1) unstable; urgency=medium

  * new upstream stable/bugfix release
  * remove all upstream-applied patches
  * d/patches/note-missing-module-pkg-name.diff: fixup
  * replace fix for CVE-2023-6683 (A different fix from upstream)
  * remove the mistakenly-added temp file in d/qemu-block-extra/
  * d/.gitignore: refresh

qemu (1:8.2.0+ds-5) unstable; urgency=medium

  * d/rules, d/run-qemu.mount: use dh_installsystemd to install run-qemu.mount
    (Closes: #1060087)
  * update hppa and seabios-hppa patch series
  * ui-clipboard-avoid-crash-upon-request-when-clipboard-CVE-2023-6683.patch
    (Closes: #1060749, CVE-2023-6683)
  * +target-s390x-Fix-LAE-setting-a-wrong-access-register.patch
  * +tcg-s390x-Fix-encoding-of-VRIc-VRSa-VRSc-insns.patch
    fix chacha20 issue on s390x
  * update hw-vfio-fix-iteration-over-global-VFIODevice-list.patch...

Read more...

Changed in qemu (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

After discussing the release-upgrade options in a mailing list thread[1], and internally with some colleagues, I have decided to not change the release upgrader to handle the glusterfs demotion. This is an opinion, and I might change it depending on feedback on the 24.04 release and/or beta. The release upgrade is only enabled for LTS versions at the first point release, so there is time to gather feedback until then.

1. https://lists.ubuntu.com/archives/ubuntu-devel/2024-January/042872.html
2. https://lists.ubuntu.com/archives/ubuntu-devel/2024-January/042876.html

Changed in ubuntu-release-upgrader (Ubuntu):
status: Triaged → Opinion
Changed in ubuntu-release-notes:
assignee: nobody → Andreas Hasenack (ahasenack)
status: New → Confirmed
Changed in glusterfs (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Ubuntu Noble release notes[1] updated with the glusterfs demotion information, and impact on samba and qemu packages.

1. https://discourse.ubuntu.com/t/noble-numbat-release-notes/39890

Changed in ubuntu-release-notes:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.