Use Debian-specific partx path in kpartx rule

Bug #2064201 reported by Chengen Du
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
multipath-tools (Ubuntu)
New
Undecided
Unassigned
Bionic
In Progress
Undecided
Chengen Du
Focal
Fix Committed
Undecided
Chengen Du

Bug Description

[Impact]
The issue arises from the installation of the udev rules file /lib/udev/rules.d/68-del-part-nodes.rules by kpartx.
This file references /usr/sbin/partx, but on Debian, partx is located in /usr/bin.
This incorrect path leads to the following error:
systemd-udevd[3302364]: sdrg: Process '/usr/sbin/partx -d --nr 1-1024 /dev/sdrg' failed with exit code 1.

[Fix]
The upstream has a patched fix available.
https://salsa.debian.org/linux-blocks-team/multipath-tools/-/blob/master/debian/patches/0003-kpartx-rules-use-Debian-specific-partx-path.patch?ref_type=heads

[Test Plan]
1. Prepare a VM with two NICs and setup an iSCSI target
root@focal:~# cat /etc/tgt/conf.d/iscsi.conf
<target iqn.2024-05.storage.com:disk1>
 backing-store /dev/sdX
</target>
2. Prepare another VM and execute iSCSI discovery and login
iscsiadm -m discovery -t sendtargets -p XXX
iscsiadm -m node --login
3. Show multipath topology
multipath -ll
4. Use the following command to trigger the udev rule
udevadm trigger --subsystem-match="block" --name-match=sdX
5. Confirm that there is no following error in /var/log/syslog
systemd-udevd[1788]: sdX: Process '/usr/sssbin/partx -d --nr 1-1024 /dev/sdX' failed with exit code 1.

[Where problems could occur]
The patch specifically targets a single udev rule responsible for deleting partition devnodes for slave devices associated with specific aggregate devices, like multipath. This modification solely adjusts the path of the partx command. If the path is incorrect, the devnode will persist.

Revision history for this message
Chengen Du (chengendu) wrote :

debdiff for Bionic

Revision history for this message
Chengen Du (chengendu) wrote :

debdiff for Focal

Changed in multipath-tools (Ubuntu Bionic):
assignee: nobody → Chengen Du (chengendu)
Changed in multipath-tools (Ubuntu Focal):
assignee: nobody → Chengen Du (chengendu)
Changed in multipath-tools (Ubuntu Bionic):
status: New → In Progress
Changed in multipath-tools (Ubuntu Focal):
status: New → In Progress
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "lp2064201-multipath-tools-bionic.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thank you for the patches.

I uploaded the Focal changes after verifying that the bug is indeed present there. Bionic is in ESM now so I decided not to touch it; IIRC the changes will need to go through another process in this case.

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Sorry, forgot to comment something else.

In the "Test Plan" section of the SRU text, could you please expand it a bit and also include an actual execution of the udev rule in question in order to confirm that the systemd-udev error doesn't happen anymore? It is generally not enough to just check if the new udev rule has the correct path for partx in it; we want to make sure that the execution of the rule doesn't generate any (new) errors.

Thanks.

Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Chengen, or anyone else affected,

Accepted multipath-tools into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/multipath-tools/0.8.3-1ubuntu2.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in multipath-tools (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (multipath-tools/0.8.3-1ubuntu2.4)

All autopkgtests for the newly accepted multipath-tools (0.8.3-1ubuntu2.4) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

multipath-tools/unknown (s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#multipath-tools

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Chengen Du (chengendu)
description: updated
Revision history for this message
Chengen Du (chengendu) wrote :

@sergiodj Apologies for the oversight in not providing a detailed test plan earlier. I've now updated it. Thank you for your help.

Revision history for this message
Chengen Du (chengendu) wrote :

I have followed the test plan and confirmed that the issue won't be occurred in 0.8.3-1ubuntu2.4.

root@focal:/# apt policy multipath-tools
multipath-tools:
  Installed: 0.8.3-1ubuntu2.4
  Candidate: 0.8.3-1ubuntu2.4
  Version table:
 *** 0.8.3-1ubuntu2.4 500
        500 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     0.8.3-1ubuntu2.3 500
        500 http://tw.archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages
     0.8.3-1ubuntu2.1 500
        500 http://tw.archive.ubuntu.com/ubuntu focal-security/main amd64 Packages
     0.8.3-1ubuntu2 500
        500 http://tw.archive.ubuntu.com/ubuntu focal/main amd64 Packages

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.