Awn

[patch] Applet dialogs have white backgrounds

Bug #207860 reported by Matt
2
Affects Status Importance Assigned to Milestone
Awn
Fix Released
Medium
Neil J. Patel

Bug Description

Using UbuntuStudio's GTK theme and bzr 215, an applet's dialog has a white background which can make text hard to read, such as in the main menu applet. This patch changes which style property is used to get the color. I tested it and it seems to work fine on every GTK theme I have.

See original description
Tags: patch

Related branches

lp:awn/0.4
Revision history for this message
Matt (mjz) wrote :
Revision history for this message
Mark Lee (malept) wrote :

Just to be sure, you mean bzr trunk r215, right?

Changed in awn:
status: New → Incomplete
Revision history for this message
Matt (mjz) wrote :

Yea, 215. Sorry.

description: updated
Revision history for this message
Mark Lee (malept) wrote :

Assigning to njpatel, as he is more qualified to review applet-API-related changes.

Changed in awn:
assignee: nobody → njpatel
status: Incomplete → Triaged
Revision history for this message
moonbeam (rcryderman) wrote :

I am not convinced that changing the background to GTK_STATE_PRELIGHT from GTK_STATE_NORMAL is an appropriate fix.

Can we get a screenshot of how it looks in its unpatched state?

Revision history for this message
Neil J. Patel (njpatel) wrote :

I agree with @moonbeam, changing it to PRELIGHT would break other themes AFAIK. Can you point us to the ubuntu-studio theme source please, so I can do some tests, thanks.

Revision history for this message
Neil J. Patel (njpatel) wrote :

*some other themes

Revision history for this message
Matt (mjz) wrote :

After some testing, I do not think that using prelight would work. Instead, I think changing to bg[GTK_STATE_ACTIVE] is the better option. base[GTK_STATE_NORMAL] seems to be the color of TreeViews, Entries, etc. Here are two screenshots, the first showing the difference between base[GTK_STATE_NORMAL] (AwnAppletDialog) and bg[GTK_STATE_ACTIVE] (Detach), and the second showing a normal window.
http://picasaweb.google.com/sharkbaitbobby/Sharkbaitbobby02/photo#5226696644037913090
http://picasaweb.google.com/sharkbaitbobby/Sharkbaitbobby02/photo#5228612028763205746

Attached is a patch to use bg[GTK_STATE_ACTIVE].

Revision history for this message
Michal Hruby (mhr3) wrote :

I think this should be included ASAP (also for 0.2.8), AwnAppletDialog is hardly usable with dark themes without this patch.

Revision history for this message
Mark Lee (malept) wrote :

Neil, could you review the latest patch?

Revision history for this message
Michal Hruby (mhr3) wrote :

I took the liberty to commit the patch, I've been using it for some time and works fine.

Changed in awn:
importance: Undecided → Medium
status: Triaged → Fix Committed
moonbeam (rcryderman)
Changed in awn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.