Should integrate with Seahorse

Just a question about this integration:
The current implementation directly REQUIRES that seahorse should be to be installed. Not sure whether this is essential. Anyhow, this is maybe buggy programming, or a real bug, or just a silly question....

Haven't got it here, and olive crashes on opening. (after installation it worked perfectly)

Running bzr dev 3349 and bzr-gtk trunk 463

Traceback (most recent call last):
  File "./olive-gtk", line 93, in <module>
    from bzrlib.plugins.gtk.olive import OliveGtk
  File "/home/remco/.bazaar/plugins/gtk/olive/__init__.py", line 53, in <module>
    from bzrlib.plugins.gtk.annotate.gannotate import GAnnotateWindow
  File "/home/remco/.bazaar/plugins/gtk/annotate/gannotate.py", line 31, in <module>
    from bzrlib.plugins.gtk.revisionview import RevisionView
  File "/home/remco/.bazaar/plugins/gtk/revisionview.py", line 30, in <module>
    from bzrlib.plugins.gtk import seahorse
  File "/home/remco/.bazaar/plugins/gtk/seahorse.py", line 38, in <module>
    crypto = dbus.Interface(bus.get_object(BUS_NAME, CRYPTO_PATH),
  File "/var/lib/python-support/python2.5/dbus/bus.py", line 240, in get_object
    follow_name_owner_changes=follow_name_owner_changes)
  File "/var/lib/python-support/python2.5/dbus/proxies.py", line 236, in __init__
    self._named_service = conn.activate_name_owner(bus_name)
  File "/var/lib/python-support/python2.5/dbus/bus.py", line 179, in activate_name_owner
    self.start_service_by_name(bus_name)
  File "/var/lib/python-support/python2.5/dbus/bus.py", line 277, in start_service_by_name
    'su', (bus_name, flags)))
  File "/var/lib/python-support/python2.5/dbus/connection.py", line 603, in call_blocking
    message, timeout)
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name org.gnome.seahorse was not provided by any .service files

Remco: Could I get you to try this out with the latest bzr-gtk trunk (currently at revision no 464)? I'm currently using dbus.validate_bus_name(), which seemed to work fine with my test audience...

I just upgraded my bzr-gtk (and bzr for that matter),
and I get a similar stack trace to Remco:

  File "/stuph/projects/bzr/bzr.repo/bzr.dev/bzrlib/commands.py", line 846, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/stuph/projects/bzr/bzr.repo/bzr.dev/bzrlib/commands.py", line 802, in run_bzr
    ret = run(*run_argv)
  File "/stuph/projects/bzr/bzr.repo/bzr.dev/bzrlib/commands.py", line 504, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/home/amanica/.bazaar/plugins/gtk/__init__.py", line 298, in run
    from annotate.gannotate import GAnnotateWindow
  File "/home/amanica/.bazaar/plugins/gtk/annotate/gannotate.py", line 31, in <module>
    from bzrlib.plugins.gtk.revisionview import RevisionView
  File "/home/amanica/.bazaar/plugins/gtk/revisionview.py", line 30, in <module>
    from bzrlib.plugins.gtk import seahorse
  File "/home/amanica/.bazaar/plugins/gtk/seahorse.py", line 42, in <module>
    crypto = dbus.Interface(bus.get_object(BUS_NAME, CRYPTO_PATH),
  File "/var/lib/python-support/python2.5/dbus/bus.py", line 240, in get_object
    follow_name_owner_changes=follow_name_owner_changes)
  File "/var/lib/python-support/python2.5/dbus/proxies.py", line 236, in __init__
    self._named_service = conn.activate_name_owner(bus_name)
  File "/var/lib/python-support/python2.5/dbus/bus.py", line 179, in activate_name_owner
    self.start_service_by_name(bus_name)
  File "/var/lib/python-support/python2.5/dbus/bus.py", line 277, in start_service_by_name
    'su', (bus_name, flags)))
  File "/var/lib/python-support/python2.5/dbus/connection.py", line 603, in call_blocking
    message, timeout)
DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name org.gnome.seahorse was not provided by any .service files

So now I installed seahorse, and now it works.

is this supposed to figure out if seahorse is installed, or is it assumed?
( I run kde on ubuntu gutsy,

  gtk$ bzr revno
  487
)

so, is it possible to run without seahorse after all? I miss bzr viz, but I am definitely not going to install a ton of Gnome dependencies for _one_ application.

I installed seahorse to get it to work,
but I consider it a bug which should be fixed

On Fri, May 9, 2008 at 4:08 PM, Sabin Iacob <email address hidden> wrote:

> so, is it possible to run without seahorse after all? I miss bzr viz,
> but I am definitely not going to install a ton of Gnome dependencies for
> _one_ application.
>
> --
> Should integrate with Seahorse
> https://bugs.launchpad.net/bugs/209998
> You received this bug notification because you are a direct subscriber
> of the bug.
>

--
bazaar-vcs.org
Because I don't trust Version Control Systems with less than 10255 unit
tests.