Launchpad itself

checkwatches error handling needs refactoring

Bug #225228 reported by Graham Binns on 2008-05-01

Affects		Status	Importance	Assigned to	Milestone
	Launchpad itself	Fix Released	Low	Unassigned

Bug Description

At the moment, when checkwatches encounters an error when updating bug statuses, it goes through an extended try:except:except:except block to produce the correct response (see l/c/l/scripts/checkwatches.py:419). The contents of each except block are virtually identical.

Instead of this duplication of code, we should have a single except clause that catches all exceptions of a given type (say BugWatchUpdateWarning) and which uses the exception's error message to produce the correct log output.

Tags:

Graham Binns (gmb) on 2008-05-01

Changed in malone:
assignee:	nobody → gmb
importance:	Undecided → Low
milestone:	none → 1.2.5
status:	New → Confirmed

Björn Tillenius (bjornt) on 2008-05-07

Changed in malone:
milestone:	1.2.5 → 1.2.6

Björn Tillenius (bjornt) on 2008-05-28

Changed in malone:
milestone:	1.2.6 → none

Graham Binns (gmb) on 2010-01-22

Changed in malone:
assignee:	Graham Binns (gmb) → nobody

Curtis Hovey (sinzui) on 2010-06-25

visibility:

private → public

William Grant (wgrant) on 2011-05-30

Changed in launchpad:
status:	Triaged → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.