bzr-email fails to send via a gmail tls smtp connection (needs ehlo cmd)

Actually, this was already fixed in bzrlib (in a more complete way)

email was meant to use the one provided by bzrlib if it was available, which is what the attached patch does

Scott, could you try John's patch and let me know if it fixes things for
you.

Cheers,
Rob

I'm guessing he'll find it fail. At least here I get:

  File "C:\Users\jameinel\dev\bzr\plugins\email\emailer.py", line 228, in _send_using_smtplib
    smtp.send_text_and_attachment_email(from_addr, to_addrs,
AttributeError: 'SMTPConnection' object has no attribute 'send_text_and_attachment_email'

It seems we have some api skew between what is available from bzrlib and what is available only in the email plugin.

Hi,

John's patch worked perfectly for me on bzr 1.5.

-scott

On Tue, Jul 22, 2008 at 12:48 AM, Robert Collins
<email address hidden> wrote:
> Scott, could you try John's patch and let me know if it fixes things for
> you.
>
> Cheers,
> Rob
>
> --
> bzr-email fails to send via a gmail tls smtp connection (needs ehlo cmd)
> https://bugs.launchpad.net/bugs/250514
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in A bzr commit hook that sends emails: New
>
> Bug description:
> Without the attached patch, sending mail via gmail's smtp servers fails with the error:
>
> bzr: ERROR: SMTP AUTH extension not supported by server.
>

John's patch also worked fine on bzr 1.6b3 ....

On Tue, Jul 22, 2008 at 12:48 AM, Robert Collins
<email address hidden> wrote:
> Scott, could you try John's patch and let me know if it fixes things for
> you.
>
> Cheers,
> Rob
>
> --
> bzr-email fails to send via a gmail tls smtp connection (needs ehlo cmd)
> https://bugs.launchpad.net/bugs/250514
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in A bzr commit hook that sends emails: New
>
> Bug description:
> Without the attached patch, sending mail via gmail's smtp servers fails with the error:
>
> bzr: ERROR: SMTP AUTH extension not supported by server.
>

Scratch that ... forgot to install after I patched.

It doesn't work with the same error John pointed out. Sorry for the confusion.

-scott

I am able to send emails with smtp.gmail.com without any additional patches with version 1.6