Reimporting sections using CSV does not work anymore

Bug #251866 reported by Ignas Mikalajūnas
0
Affects Status Importance Assigned to Milestone
SchoolTool
Fix Released
High
Justas Sadzevičius

Bug Description

Section CSV import mentions that if you try importing the same CSV twice - nothing changes, and you can also Update timetables importing a CSV with the same section titles.

Wel - you can't anymore, because timetable update subscribers are not implemented properly or some events are not firing the way they should, so you get a traceback.

Changed in schooltool:
assignee: nobody → ignas
importance: Undecided → High
Revision history for this message
Tom Hoffman (tom-hoffman) wrote :

Is this still relevant?

Revision history for this message
Ignas Mikalajūnas (ignas) wrote : Re: [Bug 251866] Re: Reimporting sections using CSV does not work anymore

Yes, both for XLS and CSV importers i am afraid, though I have yet to
test it on XLS to be sure. The instruction currently is - do not
import new sections on top of the old ones...

Revision history for this message
Tom Hoffman (tom-hoffman) wrote :

Investigate this at least prior to release.

Changed in schooltool:
assignee: Ignas Mikalajūnas (ignas) → Justas Sadzevičius (justas-pov)
milestone: none → 1.4.0
tags: added: import timetables
Changed in schooltool:
milestone: 1.4.0 → next
Changed in schooltool:
milestone: next → 1.5.2
Revision history for this message
Tom Hoffman (tom-hoffman) wrote :

Please double-check this before the Maverick release, Justas.

Changed in schooltool:
status: New → Triaged
Changed in schooltool:
milestone: 1.5.2 → 1.5.3
Changed in schooltool:
assignee: Justas Sadzevičius (justas-pov) → Douglas Cerna (replaceafill)
Changed in schooltool:
assignee: Douglas Cerna (replaceafill) → Justas Sadzevičius (justas-pov)
Revision history for this message
Gediminas Paulauskas (menesis) wrote :

What traceback?

This bug has been dragging so long, does anyone know what problem it is?

In flourish timetables have been changed completely and it is true that you cannot import an old CSV.

But some subscribers may be the same and still broken, no idea.

Changed in schooltool:
status: Triaged → Incomplete
milestone: 1.6.1 → none
Changed in schooltool:
milestone: none → 1.9.2
Changed in schooltool:
milestone: 1.9.2 → 1.9.3
Revision history for this message
Justas Sadzevičius (justas.sadzevicius) wrote :

Played around with this one, here's the status:

For old skin, section CSV import is not implemented with new timetables.

For flourish skin, CSV import works, but *always* creates a new section. It works this way, because it's unclear what combination of course/instructor/students uniquely defines a section (we got rid of specifying section ID).

What we can do:
a) Nothing - users just won't use CSV import to modify existing sections. No help text says otherwise.
b) Force users to figure out section id from URL in case they want to modify existing section.
c) Try to guess somehow what sections user may want to overwrite with each entry in CSV, list them, make user choose + "[ ] create new section".
d) something else?

Changed in schooltool:
status: Incomplete → In Progress
Changed in schooltool:
status: In Progress → Fix Committed
Revision history for this message
Gediminas Paulauskas (menesis) wrote :

Added section id to csv

Changed in schooltool:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.