libcompface: FTFBS - make up-to-dateness confusion on fast machines

Automatically imported from Debian bug report #261932 http://bugs.debian.org/261932

Message-ID: <email address hidden>
Date: Thu, 29 Jul 2004 00:43:29 +0100
From: James Troup <email address hidden>
To: <email address hidden>
Subject: libcompface: FTFBS - make up-to-dateness confusion on fast machines

Package: libcompface
Version: 1989.11.11-24
Severity: wishlist
Tag: patch

We ran into problems compiling libcompface on very fast machines, e.g.
libcompface.so.1.0.0 wouldn't be built because make(1) thought
'shared' was up-to-date[1]. Simply renaming the build directories to
not match the Makefile target names was sufficient to work around the
problem. I'm not sure this is the 100% right fix, as my make-fu is
rusty, but it Works For Me(tm).

http://aint.got.no-name-yet.com/patches/libcompface-too_fast_for_make.diff

--
James

[1] AFAICT make(1) couldn't tell the (miniscule) difference in time
    between the creation of 'shared' and compilation of the $(OBJECTS).

Message-ID: <email address hidden>
Date: Mon, 26 Dec 2005 21:38:25 +0100 (CET)
From: Santiago Vila <email address hidden>
To: <email address hidden>, <email address hidden>
Cc: Hakan Ardo <email address hidden>, James Troup <email address hidden>, Junichi Uekawa <email address hidden>
Subject: Re: libcompface: FTFBS - make up-to-dateness confusion on fast
 machines

severity 261932 serious
tags 261932 + patch
thanks

On Thu, 29 Jul 2004, James Troup wrote:

> Package: libcompface
> Version: 1989.11.11-24
> Severity: wishlist
> Tag: patch
>
> We ran into problems compiling libcompface on very fast machines, e.g.
> libcompface.so.1.0.0 wouldn't be built because make(1) thought
> 'shared' was up-to-date[1]. Simply renaming the build directories to
> not match the Makefile target names was sufficient to work around the
> problem. I'm not sure this is the 100% right fix, as my make-fu is
> rusty, but it Works For Me(tm).
>
> http://aint.got.no-name-yet.com/patches/libcompface-too_fast_for_make.diff
>
>
> --
> James
>
> [1] AFAICT make(1) couldn't tell the (miniscule) difference in time
> between the creation of 'shared' and compilation of the $(OBJECTS).

I've also ran into problems compiling this package. In fact, this package
seems to build sometimes, and sometimes not.

I think this is unacceptable. Packages should build 100% of the time,
not just "with a great probability", and not just "on slow enough machines".

The patch proposed by James should fix this bug.

Or, if you prefer, declaring "shared" and "static" as phony targets
should work too, as in this patch:

diff -ru libcompface-1989.11.11.orig/Makefile libcompface-1989.11.11/Makefile
--- libcompface-1989.11.11.orig/Makefile 2005-12-26 21:10:09.000000000 +0100
+++ libcompface-1989.11.11/Makefile 2005-12-26 21:10:32.154768000 +0100
@@ -94,3 +94,5 @@
 gen.o: gen.c compface.h data.h
 uncmain.o: uncmain.c compface.h data.h
 uncompface.o: uncompface.c compface.h data.h
+
+.PHONY: shared static

While we are at it, this bug was really discovered by Junichi Uekawa
back in 2002 in Bug #147607, but unfortunately, the report didn't
accurately reflect the exact nature of it, and the "real" bug
(i.e. make being confused by timestamps, as explained by James)
was still left unfixed in release 1989.11.11-24.

I'm Cc:ing all the interested parties for their information.

Thanks.

Message-Id: <email address hidden>
Date: Tue, 27 Dec 2005 10:32:06 -0800
From: Hakan Ardo <email address hidden>
To: <email address hidden>
Subject: Bug#261932: fixed in libcompface 1:1.5.2-1

Source: libcompface
Source-Version: 1:1.5.2-1

We believe that the bug you reported is fixed in the latest version of
libcompface, which is due to be installed in the Debian FTP archive:

compface_1.5.2-1_i386.deb
  to pool/main/libc/libcompface/compface_1.5.2-1_i386.deb
libcompface_1.5.2-1.diff.gz
  to pool/main/libc/libcompface/libcompface_1.5.2-1.diff.gz
libcompface_1.5.2-1.dsc
  to pool/main/libc/libcompface/libcompface_1.5.2-1.dsc
libcompface_1.5.2.orig.tar.gz
  to pool/main/libc/libcompface/libcompface_1.5.2.orig.tar.gz
libcompfaceg1-dev_1.5.2-1_i386.deb
  to pool/main/libc/libcompface/libcompfaceg1-dev_1.5.2-1_i386.deb
libcompfaceg1_1.5.2-1_i386.deb
  to pool/main/libc/libcompface/libcompfaceg1_1.5.2-1_i386.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hakan Ardo <email address hidden> (supplier of updated libcompface package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 27 Dec 2005 16:53:12 +0100
Source: libcompface
Binary: compface libcompfaceg1 libcompfaceg1-dev
Architecture: source i386
Version: 1:1.5.2-1
Distribution: unstable
Urgency: low
Maintainer: Hakan Ardo <email address hidden>
Changed-By: Hakan Ardo <email address hidden>
Description:
 compface - Compress/decompress images for mailheaders, user tools
 libcompfaceg1 - Compress/decompress images for mailheaders, libc6 runtime
 libcompfaceg1-dev - Compress/decompress images for mailheaders, libc6 devel
Closes: 199100 261932 261932 288824 322788 340392
Changes:
 libcompface (1:1.5.2-1) unstable; urgency=low
 .
   * Upgraded to v1.5.2 (closes: #261932)
   * Fixed make up-to-dateness confusion (closes: #261932)
   * Removed /usr/doc symlinks (closes: #322788)
   * Added example on how to generate header from jpeg to README.Debian
     (closes: #199100)
   * Section information included in the control file (closes: #288824)
   * libtool or *-config tools are not used (closes: #340392)
Files:
 2e68fe3c8d005779e16252ac07cb2d82 605 mail optional libcompface_1.5.2-1.dsc
 07a02f0b02eaeb6e4bbe5865acefca91 46600 mail optional libcompface_1.5.2.orig.tar.gz
 47420817c94878fd3997bfb067e080ce 9938 mail optional libcompface_1.5.2-1.diff.gz
 08c83397627219f5b8d989cee5b802d0 12816 libs optional libcompfaceg1_1.5.2-1_i386.deb
 cccd080b59b27767970d5c120c9bfcf5 12004 mail optional compface_1.5.2-1_i386.deb
 8931046d055ec1842170b72992aec1a5 15348 devel optional libcompfaceg1-dev_1.5.2-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD4DBQFDsYPrAbtddT3jfcARAmQUAKC4CUx8P2JWPwN49WhuZeRux...

Adam, something to worry about for our builds?

Our packages are fixed to circumvent this bug (and have been since warty), but I'm leaving this open as a reminder to sync to the new upstream version, overwriting our changes, once edgy opens.

Dropping severity, since this is just a "reminder" bug at this point.

Is this still a problem?

Closing bugs occasionally isn't such a bad idea... (This was fixed ages ago)