AssigneeEmailCommand and DBSchemaEditEmailCommand lack execute() methods

Bug #2968 reported by Christian Reis
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Björn Tillenius

Bug Description

The message below failed to be processed by launchpad:

http://librarian.launchpad.net/561687/561720/wFAov5QoOV42Hd2sM08okjdeUHP.msg

The error was:

AttributeError: 'AssigneeEmailCommand' object has no attribute 'execute'

Both AssigneeEmailCommand and DBSchemaEditEmailCommand lack execute() methods and are probably untested, unless I am confused by the source code. This means that SeverityEmailCommand and StatusEmailCommand are probably broken too, right?

Tags: lp-bugs
Revision history for this message
Christian Reis (kiko) wrote :

Sorry, only AssigneeEmailCommand actually lacks an execute() method. It probably lacks a test, because I think the only thing wrong there is that it's using the wrong base class -- it should be using EditEmailCommand.

Revision history for this message
Björn Tillenius (bjornt) wrote :

They are tested when they are used as a sub command of the affects command.

Changed in malone:
assignee: nobody → bjornt
status: New → Accepted
Revision history for this message
Christian Reis (kiko) wrote :

Even AssigneeEmailCommand? Because the failure email I got from stuart does include an affects line and yet still failed.

Changed in malone:
status: Accepted → PendingUpload
Changed in malone:
status: PendingUpload → Fixed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.